firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix CupertinoSwitch accessibility (#19927)

Browse Source
This commit is contained in:
xster 2018-07-30 11:18:32 -07:00 committed by GitHub
parent dfe5b591a6
commit cded7efbd0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 46 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

77
examples/flutter_gallery/lib/demo/cupertino/cupertino_switch_demo.dart
View File

@ -26,42 +26,51 @@ class _CupertinoSwitchDemoState extends State<CupertinoSwitchDemo> {
child: new Column( child: new Column(
mainAxisAlignment: MainAxisAlignment.spaceAround, mainAxisAlignment: MainAxisAlignment.spaceAround,
children: <Widget>[ children: <Widget>[
new Column( new Semantics(
children: <Widget>[ container: true,
new CupertinoSwitch( child: new Column(
value: _switchValue, children: <Widget>[
onChanged: (bool value) { new CupertinoSwitch(
setState(() { value: _switchValue,
_switchValue = value; onChanged: (bool value) {
}); setState(() {
}, _switchValue = value;
), });
const Text( },
'Active' ),
), const Text(
], 'Active'
),
],
),
), ),
new Column( new Semantics(
children: const <Widget>[ container: true,
const CupertinoSwitch( child: new Column(
value: true, children: const <Widget>[
onChanged: null, const CupertinoSwitch(
), value: true,
const Text( onChanged: null,
'Disabled' ),
), const Text(
], 'Disabled'
),
],
),
), ),
new Column( new Semantics(
children: const <Widget>[ container: true,
const CupertinoSwitch( child: new Column(
value: false, children: const <Widget>[
onChanged: null, const CupertinoSwitch(
), value: false,
const Text( onChanged: null,
'Disabled' ),
), const Text(
], 'Disabled'
),
],
),
), ),
], ],
), ),

5
packages/flutter/lib/src/cupertino/switch.dart
View File

@ -380,10 +380,11 @@ class _RenderCupertinoSwitch extends RenderConstrainedBox {
void describeSemanticsConfiguration(SemanticsConfiguration config) { void describeSemanticsConfiguration(SemanticsConfiguration config) {
super.describeSemanticsConfiguration(config); super.describeSemanticsConfiguration(config);
config.isSemanticBoundary = isInteractive;
if (isInteractive) if (isInteractive)
config.onTap = _handleTap; config.onTap = _handleTap;
config.isChecked = _value;
config.isEnabled = isInteractive;
config.isToggled = _value;
} }
final CupertinoThumbPainter _thumbPainter = new CupertinoThumbPainter(); final CupertinoThumbPainter _thumbPainter = new CupertinoThumbPainter();