firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix clipBehavior ignored in Scrollable of SingleChildScrollView (#133696)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/133330

The clipBehavior was not passed to the underlying Scrollable, which informs things like the clip on the StretchingOverscrollIndicator.
This commit is contained in:
Kate Lovett 2023-08-31 18:50:39 -05:00 committed by GitHub
parent 956999a4b9
commit cf051e7db2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/flutter/lib/src/widgets/single_child_scroll_view.dart
View File

@ -248,6 +248,7 @@ class SingleChildScrollView extends StatelessWidget {
controller: scrollController,
physics: physics,
restorationId: restorationId,
clipBehavior: clipBehavior,
viewportBuilder: (BuildContext context, ViewportOffset offset) {
return _SingleChildViewport(
axisDirection: axisDirection,

20
packages/flutter/test/widgets/single_child_scroll_view_test.dart
View File

@ -119,13 +119,29 @@ void main() {
renderObject.paint(context, Offset.zero); // ignore: avoid_dynamic_calls
expect(context.clipBehavior, equals(Clip.hardEdge));
// 3rd, pump a new widget to check that the render object can update its clip behavior.
// 3rd, check that the underlying Scrollable has the same clipBehavior
// Regression test for https://github.com/flutter/flutter/issues/133330
Finder scrollable = find.byWidgetPredicate((Widget widget) => widget is Scrollable);
expect(
(tester.widget(scrollable) as Scrollable).clipBehavior,
Clip.hardEdge,
);
// 4th, pump a new widget to check that the render object can update its clip behavior.
await tester.pumpWidget(SingleChildScrollView(clipBehavior: Clip.antiAlias, child: Container(height: 2000.0)));
expect(renderObject.clipBehavior, equals(Clip.antiAlias)); // ignore: avoid_dynamic_calls
// 4th, check that a non-default clip behavior can be sent to the painting context.
// 5th, check that a non-default clip behavior can be sent to the painting context.
renderObject.paint(context, Offset.zero); // ignore: avoid_dynamic_calls
expect(context.clipBehavior, equals(Clip.antiAlias));
// 6th, check that the underlying Scrollable has the same clipBehavior
// Regression test for https://github.com/flutter/flutter/issues/133330
scrollable = find.byWidgetPredicate((Widget widget) => widget is Scrollable);
expect(
(tester.widget(scrollable) as Scrollable).clipBehavior,
Clip.antiAlias,
);
});
testWidgets('SingleChildScrollView control test', (WidgetTester tester) async {