firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable unsafePackageSerialization as it causes issues when coverage is turned on (#23280)

Browse Source 
* Disable unsafePackageSerialization as it causes issues when coverage is
used (see https://github.com/dart-lang/sdk/issues/34841)

* Restore Coverage.
This commit is contained in:
Siva 2018-10-19 06:19:24 -07:00 committed by GitHub
parent f87a2a32fe
commit cf18d01e86
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
dev/bots/test.dart
View File

@ -194,28 +194,26 @@ Future<void> _runTests() async {
print('${bold}DONE: All tests successful.$reset'); print('${bold}DONE: All tests successful.$reset');
} }
// TODO(yjbanov): re-enable coverage collection when https://github.com/dart-lang/sdk/issues/34841 is fixed.
Future<void> _runCoverage() async { Future<void> _runCoverage() async {
print('${bold}DONE: Coverage collection SKIPPED due to https://github.com/dart-lang/sdk/issues/34841.$reset'); final File coverageFile = File(path.join(flutterRoot, 'packages', 'flutter', 'coverage', 'lcov.info'));
// final File coverageFile = File(path.join(flutterRoot, 'packages', 'flutter', 'coverage', 'lcov.info')); if (!coverageFile.existsSync()) {
// if (!coverageFile.existsSync()) { print('${red}Coverage file not found.$reset');
// print('${red}Coverage file not found.$reset'); print('Expected to find: ${coverageFile.absolute}');
// print('Expected to find: ${coverageFile.absolute}'); print('This file is normally obtained by running `flutter update-packages`.');
// print('This file is normally obtained by running `flutter update-packages`.'); exit(1);
// exit(1); }
// } coverageFile.deleteSync();
// coverageFile.deleteSync(); await _runFlutterTest(path.join(flutterRoot, 'packages', 'flutter'),
// await _runFlutterTest(path.join(flutterRoot, 'packages', 'flutter'), options: const <String>['--coverage'],
// options: const <String>['--coverage'], );
// ); if (!coverageFile.existsSync()) {
// if (!coverageFile.existsSync()) { print('${red}Coverage file not found.$reset');
// print('${red}Coverage file not found.$reset'); print('Expected to find: ${coverageFile.absolute}');
// print('Expected to find: ${coverageFile.absolute}'); print('This file should have been generated by the `flutter test --coverage` script, but was not.');
// print('This file should have been generated by the `flutter test --coverage` script, but was not.'); exit(1);
// exit(1); }
// }
// print('${bold}DONE: Coverage collection successful.$reset'); print('${bold}DONE: Coverage collection successful.$reset');
} }
Future<void> _pubRunTest( Future<void> _pubRunTest(

2
packages/flutter_tools/lib/src/test/flutter_platform.dart
View File

@ -239,7 +239,7 @@ class _Compiler {
trackWidgetCreation: trackWidgetCreation, trackWidgetCreation: trackWidgetCreation,
compilerMessageConsumer: reportCompilerMessage, compilerMessageConsumer: reportCompilerMessage,
initializeFromDill: testFilePath, initializeFromDill: testFilePath,
unsafePackageSerialization: true, unsafePackageSerialization: false,
); );
} }