From cfd0743d10c08d0880f0db49f00e3a409e395271 Mon Sep 17 00:00:00 2001 From: Konstantin Scheglov Date: Tue, 31 Aug 2021 16:46:05 -0600 Subject: [PATCH] Fix UNNECESSARY_TYPE_CHECK_TRUE violations. (#89186) --- dev/bots/test.dart | 3 --- dev/devicelab/lib/framework/manifest.dart | 1 - 2 files changed, 4 deletions(-) diff --git a/dev/bots/test.dart b/dev/bots/test.dart index 30a2177b25..d71ea5093d 100644 --- a/dev/bots/test.dart +++ b/dev/bots/test.dart @@ -455,9 +455,6 @@ Future _runBuildTests() async { Future _runExampleProjectBuildTests(Directory exampleDirectory, [File? mainFile]) async { // Only verify caching with flutter gallery. final bool verifyCaching = exampleDirectory.path.contains('flutter_gallery'); - if (exampleDirectory is! Directory) { - return; - } final String examplePath = exampleDirectory.path; final bool hasNullSafety = File(path.join(examplePath, 'null_safety')).existsSync(); final List additionalArgs = [ diff --git a/dev/devicelab/lib/framework/manifest.dart b/dev/devicelab/lib/framework/manifest.dart index a52ab10363..088c55d280 100644 --- a/dev/devicelab/lib/framework/manifest.dart +++ b/dev/devicelab/lib/framework/manifest.dart @@ -107,7 +107,6 @@ List _validateAndParseTasks(dynamic tasksYaml) { } ManifestTask _validateAndParseTask(String taskName, dynamic taskYaml) { - _checkType(taskName is String, taskName, 'Task name', 'string'); _checkType(taskYaml is YamlMap, taskYaml, 'Value of task "$taskName"', 'dictionary'); _checkKeys(taskYaml as YamlMap, 'Value of task "$taskName"', const [ 'description',