diff --git a/dev/customer_testing/ci.sh b/dev/customer_testing/ci.sh index dbc52e9fca..5b6b28c601 100755 --- a/dev/customer_testing/ci.sh +++ b/dev/customer_testing/ci.sh @@ -5,7 +5,7 @@ # This should match the ci.bat file in this directory. -# This is called from .cirrus.yml and the LUCI recipes: +# This is called from the LUCI recipes: # https://github.com/flutter/flutter/blob/main/dev/bots/suite_runners/run_customer_testing_tests.dart set -ex diff --git a/dev/devicelab/lib/framework/browser.dart b/dev/devicelab/lib/framework/browser.dart index 6e2c57566b..4219b4448e 100644 --- a/dev/devicelab/lib/framework/browser.dart +++ b/dev/devicelab/lib/framework/browser.dart @@ -45,7 +45,7 @@ class ChromeOptions { final int windowHeight; /// Launches code in "headless" mode, which allows running Chrome in - /// environments without a display, such as LUCI and Cirrus. + /// environments without a display, such as LUCI. final bool? headless; /// The port Chrome will use for its debugging protocol. diff --git a/docs/platforms/android/New-Android-version.md b/docs/platforms/android/New-Android-version.md index 9c29fd5827..6ead79eb4a 100644 --- a/docs/platforms/android/New-Android-version.md +++ b/docs/platforms/android/New-Android-version.md @@ -63,12 +63,8 @@ In the framework, update the following `.ci.yaml` entry: In the engine, you may follow [Upgrading Engine's Android API version](https://github.com/flutter/flutter/blob/main/docs/platforms/android/Upgrading-Engine's-Android-API-version.md) to update the AVD dependency. -Example Framework PR: https://github.com/flutter/flutter/pull/152498, Example Engine PR: https://github.com/flutter/engine/pull/54186 - -In flutter/packages, modify https://github.com/flutter/packages/blob/main/.cirrus.yml “firebase_test_lab_script” -Specifically the value for “--device” `./script/tool_runner.sh firebase-test-lab --device model=redfin,version=30 --exclude=script/configs/exclude_integration_Android.yaml`. - -Example PR: https://github.com/flutter/packages/pull/4430 +- Example Framework PR: . +- Example Engine PR: . #### Update documentation diff --git a/engine/src/flutter/lib/web_ui/dev/firefox_installer.dart b/engine/src/flutter/lib/web_ui/dev/firefox_installer.dart index d4fa0e5d4d..0c9851665a 100644 --- a/engine/src/flutter/lib/web_ui/dev/firefox_installer.dart +++ b/engine/src/flutter/lib/web_ui/dev/firefox_installer.dart @@ -29,8 +29,6 @@ Future getOrInstallFirefox( String requestedVersion, { StringSink? infoLog, }) async { - // These tests are aimed to run only on the Linux containers in Cirrus. - // Therefore Firefox installation is implemented only for Linux now. if (!io.Platform.isLinux && !io.Platform.isMacOS) { throw UnimplementedError( 'Firefox Installer is only supported on Linux ' diff --git a/engine/src/flutter/testing/benchmark/bin/parse_and_send.dart b/engine/src/flutter/testing/benchmark/bin/parse_and_send.dart index e81a4bda9c..a4f4ca154e 100644 --- a/engine/src/flutter/testing/benchmark/bin/parse_and_send.dart +++ b/engine/src/flutter/testing/benchmark/bin/parse_and_send.dart @@ -92,9 +92,7 @@ Future main(List args) async { // The data will be sent to the Datastore of the GCP project specified through // environment variable BENCHMARK_GCP_CREDENTIALS, or TOKEN_PATH/GCP_PROJECT. - // The engine Cirrus job has currently configured the GCP project to - // flutter-cirrus for test. We'll eventually migrate to flutter-infra project - // once the test is done. + // The engine LUCI job writes it to the `flutter-infra` project. final FlutterDestination destination = await connectFlutterDestination(); await destination.update( pointsAndDate.points, diff --git a/packages/flutter_goldens/test/comparator_selection_test.dart b/packages/flutter_goldens/test/comparator_selection_test.dart index d1c98f58d4..9bb933705b 100644 --- a/packages/flutter_goldens/test/comparator_selection_test.dart +++ b/packages/flutter_goldens/test/comparator_selection_test.dart @@ -168,7 +168,7 @@ void main() { _Comparator.skip, ); - // On Luci, with Gold, post-submit. Flutter root and Cirrus variables should have no effect. + // On Luci, with Gold, post-submit. Flutter root has no effect. expect(_testRecommendations(os: 'linux', hasGold: true, hasLuci: true), _Comparator.post); expect( _testRecommendations(os: 'linux', hasGold: true, hasLuci: true, hasFlutterRoot: true),