From d1f4822e0758cae4d3d7736b794e626c2f6412f5 Mon Sep 17 00:00:00 2001
From: Hans Muller <hansmuller@chromium.org>
Date: Fri, 17 Mar 2017 15:00:58 -0700
Subject: [PATCH] Verify that stateful hero state persists mid-flight (#8817)

---
 .../flutter/test/widgets/heroes_test.dart     | 94 +++++++++++++++++++
 1 file changed, 94 insertions(+)

diff --git a/packages/flutter/test/widgets/heroes_test.dart b/packages/flutter/test/widgets/heroes_test.dart
index 990fb01c3e..d6928e6f0e 100644
--- a/packages/flutter/test/widgets/heroes_test.dart
+++ b/packages/flutter/test/widgets/heroes_test.dart
@@ -76,6 +76,18 @@ class MutatingRoute extends MaterialPageRoute<Null> {
   }
 }
 
+class MyStatefulWidget extends StatefulWidget {
+  MyStatefulWidget({ Key key, this.value: '123' }) : super(key: key);
+  final String value;
+  @override
+  MyStatefulWidgetState createState() => new MyStatefulWidgetState();
+}
+
+class MyStatefulWidgetState extends State<MyStatefulWidget> {
+  @override
+  Widget build(BuildContext context) => new Text(config.value);
+}
+
 void main() {
   testWidgets('Heroes animate', (WidgetTester tester) async {
 
@@ -911,4 +923,86 @@ void main() {
     expect(tester.getTopLeft(find.byKey(heroBCKey)).y, 0.0);
   });
 
+  testWidgets('Stateful hero child state survives flight', (WidgetTester tester) async {
+    final MaterialPageRoute<Null> route = new MaterialPageRoute<Null>(
+      builder: (BuildContext context) {
+        return new Material(
+          child: new ListView(
+            children: <Widget>[
+              new Card(
+                child: new Hero(
+                  tag: 'H',
+                  child: new SizedBox(
+                    height: 200.0,
+                    child: new MyStatefulWidget(value: '456'),
+                  ),
+                ),
+              ),
+              new FlatButton(
+                child: new Text('POP'),
+                onPressed: () { Navigator.pop(context); }
+              ),
+            ],
+          )
+        );
+      },
+    );
+
+    await tester.pumpWidget(
+      new MaterialApp(
+        home: new Scaffold(
+          body: new Builder(
+            builder: (BuildContext context) { // Navigator.push() needs context
+              return new ListView(
+                children: <Widget> [
+                  new Card(
+                    child: new Hero(
+                      tag: 'H',
+                      child: new SizedBox(
+                        height: 100.0,
+                        child: new MyStatefulWidget(value: '456'),
+                      ),
+                    ),
+                  ),
+                  new FlatButton(
+                    child: new Text('PUSH'),
+                    onPressed: () { Navigator.push(context, route); }
+                  ),
+                ],
+              );
+            },
+          ),
+        ),
+      )
+    );
+
+    expect(find.text('456'), findsOneWidget);
+
+    // Push route.
+    await tester.tap(find.text('PUSH'));
+    await tester.pump();
+    await tester.pump();
+
+    // Push flight underway.
+    await tester.pump(const Duration(milliseconds: 100));
+    expect(find.text('456'), findsOneWidget);
+
+    // Push flight finished.
+    await tester.pump(const Duration(milliseconds: 300));
+    expect(find.text('456'), findsOneWidget);
+
+    // Pop route.
+    await tester.tap(find.text('POP'));
+    await tester.pump();
+    await tester.pump();
+
+    // Pop flight underway.
+    await tester.pump(const Duration(milliseconds: 100));
+    expect(find.text('456'), findsOneWidget);
+
+    // Pop flight finished
+    await tester.pump(const Duration(milliseconds: 300));
+    expect(find.text('456'), findsOneWidget);
+
+  });
 }