diff --git a/packages/flutter_tools/lib/src/build_system/build_system.dart b/packages/flutter_tools/lib/src/build_system/build_system.dart index 849f4f3ce0..2fa2d8e272 100644 --- a/packages/flutter_tools/lib/src/build_system/build_system.dart +++ b/packages/flutter_tools/lib/src/build_system/build_system.dart @@ -435,7 +435,7 @@ class Environment { processManager: processManager, platform: platform ?? FakePlatform(), usage: usage ?? TestUsage(), - analytics: analytics ?? NoOpAnalytics(), + analytics: analytics ?? const NoOpAnalytics(), engineVersion: engineVersion, generateDartPluginRegistry: generateDartPluginRegistry, ); diff --git a/packages/flutter_tools/lib/src/ios/xcodeproj.dart b/packages/flutter_tools/lib/src/ios/xcodeproj.dart index 2fb2764748..773c7356f4 100644 --- a/packages/flutter_tools/lib/src/ios/xcodeproj.dart +++ b/packages/flutter_tools/lib/src/ios/xcodeproj.dart @@ -92,7 +92,7 @@ class XcodeProjectInterpreter { logger: BufferLogger.test(), version: version, build: build, - analytics: analytics ?? NoOpAnalytics(), + analytics: analytics ?? const NoOpAnalytics(), ); } diff --git a/packages/flutter_tools/lib/src/reporting/unified_analytics.dart b/packages/flutter_tools/lib/src/reporting/unified_analytics.dart index 3d58a8d1d4..e852d3aec1 100644 --- a/packages/flutter_tools/lib/src/reporting/unified_analytics.dart +++ b/packages/flutter_tools/lib/src/reporting/unified_analytics.dart @@ -39,7 +39,7 @@ Analytics getAnalytics({ runningOnBot || // Ignore when suppressed by FLUTTER_SUPPRESS_ANALYTICS. suppressEnvFlag) { - return NoOpAnalytics(); + return const NoOpAnalytics(); } // Providing an override of the [Analytics] instance is preferred when diff --git a/packages/flutter_tools/pubspec.yaml b/packages/flutter_tools/pubspec.yaml index 49db227e1e..2e43e4246c 100644 --- a/packages/flutter_tools/pubspec.yaml +++ b/packages/flutter_tools/pubspec.yaml @@ -51,7 +51,7 @@ dependencies: http_multi_server: 3.2.1 convert: 3.1.1 async: 2.11.0 - unified_analytics: 5.8.1 + unified_analytics: 5.8.4 cli_config: 0.1.2 graphs: 2.3.1 @@ -119,4 +119,4 @@ dartdoc: # Exclude this package from the hosted API docs. nodoc: true -# PUBSPEC CHECKSUM: 588f +# PUBSPEC CHECKSUM: c492 diff --git a/packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart index 33629ec668..ca9c45d67a 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart @@ -157,7 +157,7 @@ void main() { preliminaryMDnsClient: FakeMDnsClient([], >{}), logger: logger, flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ), }); @@ -221,7 +221,7 @@ void main() { preliminaryMDnsClient: FakeMDnsClient([], >{}), logger: logger, flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ), Signals: () => FakeSignals(), }); @@ -291,7 +291,7 @@ void main() { preliminaryMDnsClient: FakeMDnsClient([], >{}), logger: logger, flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ), ProcessManager: () => FakeProcessManager.empty(), }); @@ -361,7 +361,7 @@ void main() { ), logger: logger, flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ), }); @@ -432,7 +432,7 @@ void main() { ), logger: logger, flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ), }); @@ -507,7 +507,7 @@ void main() { ), logger: logger, flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ), }); @@ -582,7 +582,7 @@ void main() { ), logger: logger, flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ), }); diff --git a/packages/flutter_tools/test/general.shard/base/analyze_size_test.dart b/packages/flutter_tools/test/general.shard/base/analyze_size_test.dart index 67f3bd5a13..274b5c2237 100644 --- a/packages/flutter_tools/test/general.shard/base/analyze_size_test.dart +++ b/packages/flutter_tools/test/general.shard/base/analyze_size_test.dart @@ -67,7 +67,7 @@ void main() { logger: logger, appFilenamePattern: RegExp(r'lib.*app\.so'), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final Archive archive = Archive() @@ -152,7 +152,7 @@ void main() { logger: logger, appFilenamePattern: RegExp(r'lib.*app\.so'), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final Archive archive = Archive() @@ -195,7 +195,7 @@ void main() { logger: logger, appFilenamePattern: RegExp(r'lib.*app\.so'), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final Directory outputDirectory = fileSystem.directory('example/out/foo.app') @@ -239,7 +239,7 @@ void main() { logger: logger, appFilenamePattern: RegExp(r'lib.*app\.so'), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final Directory outputDirectory = fileSystem.directory('example/out/foo.app')..createSync(recursive: true); diff --git a/packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart b/packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart index 66a732180a..fa40af78e2 100644 --- a/packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart +++ b/packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart @@ -73,7 +73,7 @@ void main() { platform: platform, processManager: fakeProcessManager, usage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); }); @@ -186,7 +186,7 @@ void main() { platform: platform, processManager: fakeProcessManager, usage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); fileSystem.file(xcodebuild).deleteSync(); @@ -513,7 +513,7 @@ void main() { platform: platform, processManager: fakeProcessManager, usage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect(await xcodeProjectInterpreter.getInfo(workingDirectory), isNotNull); @@ -540,7 +540,7 @@ void main() { platform: platform, processManager: fakeProcessManager, usage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect(() => xcodeProjectInterpreter.getInfo(workingDirectory), throwsToolExit(message: stderr)); @@ -567,7 +567,7 @@ void main() { platform: platform, processManager: fakeProcessManager, usage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect(() => xcodeProjectInterpreter.getInfo(workingDirectory), throwsToolExit(message: stderr)); diff --git a/packages/flutter_tools/test/general.shard/macos/xcode_test.dart b/packages/flutter_tools/test/general.shard/macos/xcode_test.dart index 1e52992345..b250f15cba 100644 --- a/packages/flutter_tools/test/general.shard/macos/xcode_test.dart +++ b/packages/flutter_tools/test/general.shard/macos/xcode_test.dart @@ -517,7 +517,7 @@ void main() { fileSystem: fileSystem, coreDeviceControl: FakeIOSCoreDeviceControl(), xcodeDebug: FakeXcodeDebug(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); }); diff --git a/packages/flutter_tools/test/general.shard/mdns_discovery_test.dart b/packages/flutter_tools/test/general.shard/mdns_discovery_test.dart index 0c3dad1701..27eb5a9a8b 100644 --- a/packages/flutter_tools/test/general.shard/mdns_discovery_test.dart +++ b/packages/flutter_tools/test/general.shard/mdns_discovery_test.dart @@ -60,7 +60,7 @@ void main() { preliminaryMDnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final MDnsVmServiceDiscoveryResult? result = await portDiscovery.queryForAttach(); @@ -84,7 +84,7 @@ void main() { preliminaryMDnsClient: emptyClient, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final MDnsVmServiceDiscoveryResult? result = await portDiscovery.queryForAttach(); @@ -112,7 +112,7 @@ void main() { preliminaryMDnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect(portDiscovery.queryForAttach, throwsToolExit()); @@ -136,7 +136,7 @@ void main() { preliminaryMDnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final MDnsVmServiceDiscoveryResult? result = await portDiscovery.queryForAttach(); @@ -164,7 +164,7 @@ void main() { preliminaryMDnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect(portDiscovery.queryForAttach, throwsToolExit()); @@ -176,7 +176,7 @@ void main() { preliminaryMDnsClient: emptyClient, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final int? port = (await portDiscovery.queryForAttach())?.port; @@ -228,7 +228,7 @@ void main() { preliminaryMDnsClient: emptyClient, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final int? port = (await portDiscovery.queryForAttach())?.port; expect(port, 123); @@ -256,7 +256,7 @@ void main() { preliminaryMDnsClient: emptyClient, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final MDnsVmServiceDiscoveryResult? result = await portDiscovery.queryForAttach(); expect(result?.port, 123); @@ -284,7 +284,7 @@ void main() { preliminaryMDnsClient: emptyClient, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final int? port = (await portDiscovery.queryForAttach(applicationId: 'fiz'))?.port; expect(port, 321); @@ -313,7 +313,7 @@ void main() { preliminaryMDnsClient: emptyClient, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final int? port = (await portDiscovery.queryForAttach(applicationId: 'bar'))?.port; expect(port, 1234); @@ -330,7 +330,7 @@ void main() { preliminaryMDnsClient: emptyClient, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect( () async => portDiscovery.queryForAttach(), @@ -356,7 +356,7 @@ void main() { preliminaryMDnsClient: emptyClient, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final Uri? uri = await portDiscovery.getVMServiceUriForAttach('bar', device, hostVmservicePort: 0); expect(uri.toString(), 'http://127.0.0.1:123/'); @@ -390,7 +390,7 @@ void main() { preliminaryMDnsClient: emptyClient, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final Uri? uri = await portDiscovery.getVMServiceUriForAttach( 'bar', @@ -428,7 +428,7 @@ void main() { preliminaryMDnsClient: emptyClient, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final Uri? uri = await portDiscovery.getVMServiceUriForAttach( 'bar', @@ -463,7 +463,7 @@ void main() { preliminaryMDnsClient: emptyClient, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect( portDiscovery.getVMServiceUriForAttach( @@ -494,7 +494,7 @@ void main() { preliminaryMDnsClient: emptyClient, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect( portDiscovery.getVMServiceUriForAttach( @@ -516,7 +516,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect(() async => portDiscovery.queryForLaunch(applicationId: 'app-id'), throwsAssertionError); @@ -529,7 +529,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final MDnsVmServiceDiscoveryResult? result = await portDiscovery.queryForLaunch( @@ -547,7 +547,7 @@ void main() { mdnsClient: client, logger: logger, flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final Uri? uri = await portDiscovery.getVMServiceUriForLaunch( @@ -569,7 +569,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect( () async => portDiscovery.queryForLaunch(applicationId: 'app-id', deviceVmservicePort: 123), @@ -594,7 +594,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final Uri? uri = await portDiscovery.getVMServiceUriForLaunch( 'bar', @@ -632,7 +632,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final Uri? uri = await portDiscovery.getVMServiceUriForLaunch( 'bar', @@ -670,7 +670,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final Uri? uri = await portDiscovery.getVMServiceUriForLaunch( 'bar', @@ -705,7 +705,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect( portDiscovery.getVMServiceUriForLaunch( @@ -738,7 +738,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final Uri? uri = await portDiscovery.getVMServiceUriForLaunch( @@ -768,7 +768,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect( portDiscovery.getVMServiceUriForLaunch( @@ -790,7 +790,7 @@ void main() { ), logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect(portDiscovery.deviceNameMatchesTargetName('My phone', 'My-Phone.local'), isTrue); @@ -804,7 +804,7 @@ void main() { ), logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); expect(portDiscovery.deviceNameMatchesTargetName('My phone', 'My-Phone-2.local'), isFalse); }); @@ -834,7 +834,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final MDnsVmServiceDiscoveryResult? result = await portDiscovery.firstMatchingVmService(client); expect(result?.domainName, 'srv-foo'); @@ -865,7 +865,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final MDnsVmServiceDiscoveryResult? result = await portDiscovery.firstMatchingVmService( client, @@ -895,7 +895,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final MDnsVmServiceDiscoveryResult? result = await portDiscovery.firstMatchingVmService( client, @@ -933,7 +933,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final MDnsVmServiceDiscoveryResult? result = await portDiscovery.firstMatchingVmService( client, @@ -971,7 +971,7 @@ void main() { mdnsClient: client, logger: BufferLogger.test(), flutterUsage: TestUsage(), - analytics: NoOpAnalytics(), + analytics: const NoOpAnalytics(), ); final MDnsVmServiceDiscoveryResult? result = await portDiscovery.firstMatchingVmService( client, diff --git a/packages/flutter_tools/test/general.shard/resident_runner_test.dart b/packages/flutter_tools/test/general.shard/resident_runner_test.dart index 5eedd8bf6d..d51952e353 100644 --- a/packages/flutter_tools/test/general.shard/resident_runner_test.dart +++ b/packages/flutter_tools/test/general.shard/resident_runner_test.dart @@ -30,8 +30,7 @@ import 'package:flutter_tools/src/run_cold.dart'; import 'package:flutter_tools/src/run_hot.dart'; import 'package:flutter_tools/src/version.dart'; import 'package:flutter_tools/src/vmservice.dart'; -// TODO(goderbauer): Fix this ignore when https://github.com/dart-lang/tools/issues/234 is resolved. -import 'package:unified_analytics/src/enums.dart' show DashEvent; // ignore: implementation_imports +import 'package:unified_analytics/testing.dart'; import 'package:unified_analytics/unified_analytics.dart'; import 'package:vm_service/vm_service.dart' as vm_service; diff --git a/packages/flutter_tools/test/general.shard/run_hot_test.dart b/packages/flutter_tools/test/general.shard/run_hot_test.dart index 9c149257e1..163eeb0ec1 100644 --- a/packages/flutter_tools/test/general.shard/run_hot_test.dart +++ b/packages/flutter_tools/test/general.shard/run_hot_test.dart @@ -26,7 +26,7 @@ void main() { false, 'test-reason', TestUsage(), - NoOpAnalytics(), + const NoOpAnalytics(), ); }); } diff --git a/packages/flutter_tools/test/general.shard/runner/flutter_command_test.dart b/packages/flutter_tools/test/general.shard/runner/flutter_command_test.dart index 7cd7ce5b32..2ba2a9c0d8 100644 --- a/packages/flutter_tools/test/general.shard/runner/flutter_command_test.dart +++ b/packages/flutter_tools/test/general.shard/runner/flutter_command_test.dart @@ -27,8 +27,7 @@ import 'package:flutter_tools/src/project.dart'; import 'package:flutter_tools/src/reporting/reporting.dart'; import 'package:flutter_tools/src/runner/flutter_command.dart'; import 'package:test/fake.dart'; -// TODO(goderbauer): Fix this ignore when https://github.com/dart-lang/tools/issues/234 is resolved. -import 'package:unified_analytics/src/enums.dart' show DashEvent; // ignore: implementation_imports +import 'package:unified_analytics/testing.dart'; import 'package:unified_analytics/unified_analytics.dart'; import '../../src/common.dart'; diff --git a/packages/flutter_tools/test/src/common.dart b/packages/flutter_tools/test/src/common.dart index d9d8f40587..949b6673ad 100644 --- a/packages/flutter_tools/test/src/common.dart +++ b/packages/flutter_tools/test/src/common.dart @@ -17,8 +17,7 @@ import 'package:meta/meta.dart'; import 'package:path/path.dart' as path; // flutter_ignore: package_path_import import 'package:test/test.dart' as test_package show test; import 'package:test/test.dart' hide test; -// TODO(goderbauer): Fix this ignore when https://github.com/dart-lang/tools/issues/234 is resolved. -import 'package:unified_analytics/src/enums.dart' show DevicePlatform; // ignore: implementation_imports +import 'package:unified_analytics/testing.dart'; import 'package:unified_analytics/unified_analytics.dart'; import 'fakes.dart'; diff --git a/packages/flutter_tools/test/src/context.dart b/packages/flutter_tools/test/src/context.dart index fd715864ed..7a7caf8c01 100644 --- a/packages/flutter_tools/test/src/context.dart +++ b/packages/flutter_tools/test/src/context.dart @@ -125,7 +125,7 @@ void testUsingContext( CrashReporter: () => const NoopCrashReporter(), TemplateRenderer: () => const MustacheTemplateRenderer(), BuildTargets: () => const BuildTargetsImpl(), - Analytics: () => NoOpAnalytics(), + Analytics: () => const NoOpAnalytics(), }, body: () { // To catch all errors thrown by the test, even uncaught async errors, we use a zone.