firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

InputDecorator input and hint widgets have the same width (#16894)

Browse Source
This commit is contained in:
Hans Muller 2018-04-23 13:53:15 -07:00 committed by GitHub
parent 286cd35951
commit d3d4976f63
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/material/input_decorator.dart
View File

@ -771,11 +771,11 @@ class _RenderDecoration extends RenderBox {
+ contentPadding.right); + contentPadding.right);
boxConstraints = boxConstraints.copyWith(maxWidth: inputWidth); boxConstraints = boxConstraints.copyWith(maxWidth: inputWidth);
layoutLineBox(hint);
if (label != null) // The label is not baseline aligned. if (label != null) // The label is not baseline aligned.
label.layout(boxConstraints, parentUsesSize: true); label.layout(boxConstraints, parentUsesSize: true);
boxConstraints = boxConstraints.copyWith(minWidth: inputWidth); boxConstraints = boxConstraints.copyWith(minWidth: inputWidth);
layoutLineBox(hint);
layoutLineBox(input); layoutLineBox(input);
double inputBaseline = contentPadding.top + aboveBaseline; double inputBaseline = contentPadding.top + aboveBaseline;

2
packages/flutter/test/material/input_decorator_test.dart
View File

@ -259,6 +259,8 @@ void main() {
expect(tester.getBottomLeft(find.text('hint')).dy, 28.0); expect(tester.getBottomLeft(find.text('hint')).dy, 28.0);
expect(getBorderBottom(tester), 40.0); expect(getBorderBottom(tester), 40.0);
expect(getBorderWeight(tester), 1.0); expect(getBorderWeight(tester), 1.0);
expect(tester.getSize(find.text('hint')).width, tester.getSize(find.text('text')).width);
}); });
testWidgets('InputDecorator input/label/hint layout', (WidgetTester tester) async { testWidgets('InputDecorator input/label/hint layout', (WidgetTester tester) async {