firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve container widget (#98389)

Browse Source
This commit is contained in:
Reza Mirzaee 2022-03-05 02:41:19 +03:30 committed by GitHub
parent 513df67edb
commit d61caaad26
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter/lib/src/widgets/container.dart
View File

@ -389,10 +389,9 @@ class Container extends StatelessWidget {
maxHeight: 0.0, maxHeight: 0.0,
child: ConstrainedBox(constraints: const BoxConstraints.expand()), child: ConstrainedBox(constraints: const BoxConstraints.expand()),
); );
} } else if (alignment != null) {
if (alignment != null)
current = Align(alignment: alignment!, child: current); current = Align(alignment: alignment!, child: current);
}
final EdgeInsetsGeometry? effectivePadding = _paddingIncludingDecoration; final EdgeInsetsGeometry? effectivePadding = _paddingIncludingDecoration;
if (effectivePadding != null) if (effectivePadding != null)

15
packages/flutter/test/widgets/container_test.dart
View File

@ -633,6 +633,21 @@ void main() {
expect(tapped, false); expect(tapped, false);
}); });
testWidgets('Container discards alignment when the child parameter is null and constraints is not Tight', (WidgetTester tester) async {
await tester.pumpWidget(
Container(
decoration: const BoxDecoration(
borderRadius: BorderRadius.all(Radius.circular(1)),
),
alignment: Alignment.centerLeft
));
expect(
find.byType(Align),
findsNothing,
);
});
testWidgets('using clipBehaviour and shadow, should not clip the shadow', (WidgetTester tester) async { testWidgets('using clipBehaviour and shadow, should not clip the shadow', (WidgetTester tester) async {
final Container container = Container( final Container container = Container(
clipBehavior: Clip.hardEdge, clipBehavior: Clip.hardEdge,