firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cleanup unawaited futures lints (#5945)

Browse Source
This commit is contained in:
Dan Rubel 2016-09-20 07:32:09 -04:00 committed by GitHub
parent 869371fc3e
commit d65460e7a5
3 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/devicelab/lib/framework/framework.dart
View File

@ -83,7 +83,7 @@ class _TaskRunner {
} on TimeoutException catch (_) { } on TimeoutException catch (_) {
return new TaskResult.failure('Task timed out after $taskTimeout'); return new TaskResult.failure('Task timed out after $taskTimeout');
} finally { } finally {
forceQuitRunningProcesses(); await forceQuitRunningProcesses();
_closeKeepAlivePort(); _closeKeepAlivePort();
} }
} }

1
dev/devicelab/lib/framework/runner.dart
View File

@ -34,6 +34,7 @@ Future<Map<String, dynamic>> runTask(String taskName) async {
bool runnerFinished = false; bool runnerFinished = false;
// ignore: unawaited_futures
runner.exitCode.then((_) { runner.exitCode.then((_) {
runnerFinished = true; runnerFinished = true;
}); });

1
dev/devicelab/lib/framework/utils.dart
View File

@ -166,6 +166,7 @@ Future<Process> startProcess(String executable, List<String> arguments,
ProcessInfo procInfo = new ProcessInfo(command, proc); ProcessInfo procInfo = new ProcessInfo(command, proc);
_runningProcesses.add(procInfo); _runningProcesses.add(procInfo);
// ignore: unawaited_futures
proc.exitCode.then((_) { proc.exitCode.then((_) {
_runningProcesses.remove(procInfo); _runningProcesses.remove(procInfo);
}); });