firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make analysis of sample code work in OS-X (#11139)

Browse Source 
The output of the analyzer gives the full path to the Dart file, so
we had to adjust the string matching to account for that.

https://github.com/flutter/flutter/issues/7894
This commit is contained in:
Todd Volkert 2017-07-10 14:42:45 -07:00 committed by GitHub
parent a796438086
commit d82ca0f6d0
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dev/bots/analyze-sample-code.dart
View File

@ -172,16 +172,17 @@ dependencies:
int errorCount = 0; int errorCount = 0;
for (String error in errors) { for (String error in errors) {
const String kBullet = ' • '; const String kBullet = ' • ';
const String kAt = ' at main.dart:';
const String kColon = ':'; const String kColon = ':';
final RegExp atRegExp = new RegExp(r' at .*main.dart:');
final int start = error.indexOf(kBullet); final int start = error.indexOf(kBullet);
final int end = error.indexOf(kAt); final int end = error.indexOf(atRegExp);
if (start >= 0 && end >= 0) { if (start >= 0 && end >= 0) {
final String message = error.substring(start + kBullet.length, end); final String message = error.substring(start + kBullet.length, end);
final int colon2 = error.indexOf(kColon, end + kAt.length); final String atMatch = atRegExp.firstMatch(error)[0];
final int colon2 = error.indexOf(kColon, end + atMatch.length);
if (colon2 < 0) if (colon2 < 0)
throw 'failed to parse error message: $error'; throw 'failed to parse error message: $error';
final String line = error.substring(end + kAt.length, colon2); final String line = error.substring(end + atMatch.length, colon2);
final int bullet2 = error.indexOf(kBullet, colon2); final int bullet2 = error.indexOf(kBullet, colon2);
if (bullet2 < 0) if (bullet2 < 0)
throw 'failed to parse error message: $error'; throw 'failed to parse error message: $error';