firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove PaintLayerPaintingChildClippingMaskPhase.

Browse Source 
It's never set. It was added in
7176977ba5%5E%21/#F21

The test cases from that patch seem to pass.
Included one in this patch.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/772193004
This commit is contained in:
Ojan Vafai 2014-12-02 20:12:23 -08:00
parent 253d078c89
commit d8fbaa8bda
2 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
engine/src/flutter/tests/clipping/canvas-rounded-corners-expected.txt Normal file
View File

@ -0,0 +1,24 @@
layer at (0,0) size 800x600
RenderView {#document} at (0,0) size 800x600
layer at (0,0) size 800x353
RenderBlock {sky} at (0,0) size 800x353
RenderBlock {h3} at (0,0) size 800x19
RenderBlock (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 92x19
text run at (0,0) width 92: "It passes if:"
RenderBlock {ul} at (0,19) size 800x57
RenderBlock {li} at (0,0) size 800x19
RenderBlock (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 511x19
text run at (0,0) width 511: "the canvas content has rounded corners (top-left and top-right)"
RenderBlock {li} at (0,19) size 800x19
RenderBlock (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 457x19
text run at (0,0) width 457: "the 10px red border is visible around the canvas content"
RenderBlock {li} at (0,38) size 800x19
RenderBlock (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 200x19
text run at (0,0) width 200: "gray border is not visible"
layer at (0,76) size 277x277
RenderHTMLCanvas {canvas} at (0,76) size 277x277 [bgcolor=#808080] [border: (10px solid #FF0000)]

24
engine/src/flutter/tests/clipping/canvas-rounded-corners.sky Normal file
View File

@ -0,0 +1,24 @@
<sky>
<import src="../resources/dump-as-render-tree.sky" />
<style>
canvas {
background-color: gray;
border: 10px solid red;
border-radius: 200px 100px 0px 0px;
}
</style>
<!-- TODO(ojan): Make this a reftest. -->
<h3>It passes if:</h3>
<ul>
<li>the canvas content has rounded corners (top-left and top-right)</li>
<li>the 10px red border is visible around the canvas content</li>
<li>gray border is not visible</li>
</ul>
<canvas id="theCanvas" width="257" height="257"></canvas>
<script>
var theCanvas = document.getElementById('theCanvas');
var context = theCanvas.getContext('2d');
context.fillStyle = 'green';
context.fillRect(0, 0, theCanvas.width, theCanvas.width);
</script>
</sky>