From d9b73a2b7a1c1d3e1eeb6782d5f400a7ce0e59a8 Mon Sep 17 00:00:00 2001
From: Adam Barth <github@adambarth.com>
Date: Tue, 12 Apr 2016 12:42:14 -0700
Subject: [PATCH] Improve docs about why we pin analyzer (#3254)

---
 packages/flutter_test/pubspec.yaml  | 10 ++++++++--
 packages/flutter_tools/pubspec.yaml | 22 ++++++++--------------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/packages/flutter_test/pubspec.yaml b/packages/flutter_test/pubspec.yaml
index 5c55261917..baeae32238 100644
--- a/packages/flutter_test/pubspec.yaml
+++ b/packages/flutter_test/pubspec.yaml
@@ -1,9 +1,15 @@
 name: flutter_test
 dependencies:
-  test: 0.12.13
   quiver: ^0.21.4
 
-  # Not needed directly but transitively included due to package:test.
+  # The flutter tools depend on very specific internal implementation
+  # details of the 'test' package, which change between versions, so
+  # here we pin it precisely to avoid version skew across our packages.
+  test: 0.12.13
+
+  # We don't actually depend on 'analyzer', but 'test' does. We pin the
+  # version of analyzer we depend on to avoid version skew across our
+  # packages.
   analyzer: 0.27.2
 
   flutter:
diff --git a/packages/flutter_tools/pubspec.yaml b/packages/flutter_tools/pubspec.yaml
index a3a50b2834..7637f0faa7 100644
--- a/packages/flutter_tools/pubspec.yaml
+++ b/packages/flutter_tools/pubspec.yaml
@@ -25,21 +25,15 @@ dependencies:
   flx:
     path: ../flx
 
-  test: 0.12.13 # see note below
-  analyzer: '0.27.2' # see note below
+  # We depend on very specific internal implementation details of the
+  # 'test' package, which change between versions, so here we pin it
+  # precisely.
+  test: 0.12.13
 
-# A note about 'test':
-# We depend on very specific internal implementation details of the
-# 'test' package, which change between versions, so here we pin it
-# precisely.
-
-# A note about 'analyzer':
-# We don't actually depend on 'analyzer', but 'test' does. We aren't
-# compatible with some older versions of 'analyzer'. We lie here,
-# saying we do depend on it, so that we constrain the version that
-# 'test' will get to a version that we'll probably be ok with. (This
-# is why there's no upper bound on our dependency.)
-# See also https://github.com/dart-lang/pub/issues/1356
+  # We don't actually depend on 'analyzer', but 'test' does. We pin the
+  # version of analyzer we depend on to avoid version skew across our
+  # packages.
+  analyzer: 0.27.2
 
 dev_dependencies:
   mockito: ^0.11.0