firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #939 from devoncarew/update_service_extensions

Browse Source 
remove todos for service extension params
This commit is contained in:
Devon Carew 2015-12-15 11:57:47 -08:00
commit d9cab80c8a
1 changed files with 5 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
packages/flutter/lib/src/rendering/debug.dart
View File

@ -81,7 +81,7 @@ void initServiceExtensions() {
/// Just respond to the request. Clients can use the existence of this call to /// Just respond to the request. Clients can use the existence of this call to
/// know that the debug client is a Flutter app. /// know that the debug client is a Flutter app.
Future<developer.ServiceExtensionResponse> _flutter(String method, Map<String, dynamic> parameters) { Future<developer.ServiceExtensionResponse> _flutter(String method, Map<String, String> parameters) {
return new Future<developer.ServiceExtensionResponse>.value( return new Future<developer.ServiceExtensionResponse>.value(
new developer.ServiceExtensionResponse.result(JSON.encode({ new developer.ServiceExtensionResponse.result(JSON.encode({
'type': '_extensionType', 'type': '_extensionType',
@ -91,11 +91,9 @@ Future<developer.ServiceExtensionResponse> _flutter(String method, Map<String, d
} }
/// Toggle the [debugPaintSizeEnabled] setting. /// Toggle the [debugPaintSizeEnabled] setting.
Future<developer.ServiceExtensionResponse> _debugPaint(String method, Map<String, dynamic> parameters) { Future<developer.ServiceExtensionResponse> _debugPaint(String method, Map<String, String> parameters) {
if (parameters.containsKey('enabled')) { if (parameters.containsKey('enabled')) {
// TODO(devoncarew): This is a work around for a VM bug: sdk/25208 - all debugPaintSizeEnabled = parameters['enabled'] == 'true';
// params are coerced to strings.
debugPaintSizeEnabled = parameters['enabled'].toString() == 'true';
// Redraw everything - mark the world as dirty. // Redraw everything - mark the world as dirty.
RenderObjectVisitor visitor; RenderObjectVisitor visitor;
@ -116,18 +114,9 @@ Future<developer.ServiceExtensionResponse> _debugPaint(String method, Map<String
} }
/// Manipulate the scheduler's [timeDilation] field. /// Manipulate the scheduler's [timeDilation] field.
Future<developer.ServiceExtensionResponse> _timeDilation(String method, Map<String, dynamic> parameters) { Future<developer.ServiceExtensionResponse> _timeDilation(String method, Map<String, String> parameters) {
if (parameters.containsKey('timeDilation')) { if (parameters.containsKey('timeDilation')) {
// TODO(devoncarew): Workaround for https://github.com/dart-lang/sdk/issues/25208. timeDilation = double.parse(parameters['timeDilation']);
dynamic param = parameters['timeDilation'];
if (param is String) {
param = double.parse(param);
} else if (param is num) {
param = param.toDouble();
}
timeDilation = param;
} else {
timeDilation = 1.0;
} }
return new Future<developer.ServiceExtensionResponse>.value( return new Future<developer.ServiceExtensionResponse>.value(