firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update 'dump-info' usage for dart2js builds (#156187)

Browse Source 
Dart2js updated its CLI to support generating a 'dump-info' json file by passing a "--stage" option. The "dump-info-all" stage performs a full compilation (from the provided dill) and then also generates the dump info file.

Tested via the `flutter-dev` CLI locally. This results in the same output but with the addition of an extra `main.dart.js.info.json` file.
This commit is contained in:
Nate Biggs 2024-10-07 16:06:18 -04:00 committed by GitHub
parent 86ce72d46d
commit da71e6e93d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/web/compiler_config.dart
View File

@ -115,7 +115,7 @@ class JsCompilerConfig extends WebCompilerConfig {
if (buildMode != BuildMode.release) '--no-minify', if (buildMode != BuildMode.release) '--no-minify',
...toSharedCommandOptions(buildMode), ...toSharedCommandOptions(buildMode),
'-O$optimizationLevel', '-O$optimizationLevel',
if (dumpInfo) '--dump-info', if (dumpInfo) '--stage=dump-info-all',
if (noFrequencyBasedMinification) '--no-frequency-based-minification', if (noFrequencyBasedMinification) '--no-frequency-based-minification',
if (csp) '--csp', if (csp) '--csp',
]; ];

2
packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart
View File

@ -953,7 +953,7 @@ void main() {
'--no-minify', '--no-minify',
'--no-source-maps', '--no-source-maps',
'-O4', '-O4',
'--dump-info', '--stage=dump-info-all',
'-o', '-o',
environment.buildDir.childFile('main.dart.js').absolute.path, environment.buildDir.childFile('main.dart.js').absolute.path,
environment.buildDir.childFile('app.dill').absolute.path, environment.buildDir.childFile('app.dill').absolute.path,