firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Throw error on unexpected positional arguments (#130274)

Browse Source 
This PR fixes ignoring when random positional arguments added to the
`flutter gen-l10n`.

So we are no longer able to call `flutter gen-l10n hello world` or
`flutter gen-l10n --format false`.

Fixes https://github.com/flutter/flutter/issues/118203
This commit is contained in:
Tae Hyung Kim 2023-07-10 12:12:23 -07:00 committed by GitHub
parent f731af6371
commit dabd7b3bb5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter_tools/lib/src/commands/generate_localizations.dart
View File

@ -5,6 +5,7 @@
import 'package:process/process.dart'; import 'package:process/process.dart';
import '../artifacts.dart'; import '../artifacts.dart';
import '../base/common.dart';
import '../base/file_system.dart'; import '../base/file_system.dart';
import '../base/logger.dart'; import '../base/logger.dart';
import '../localizations/gen_l10n.dart'; import '../localizations/gen_l10n.dart';
@ -217,6 +218,10 @@ class GenerateLocalizationsCommand extends FlutterCommand {
@override @override
Future<FlutterCommandResult> runCommand() async { Future<FlutterCommandResult> runCommand() async {
// Validate the rest of the args.
if (argResults!.rest.isNotEmpty) {
throwToolExit('Unexpected positional argument "${argResults!.rest.first}".');
}
// Keep in mind that this is also defined in the following locations: // Keep in mind that this is also defined in the following locations:
// 1. flutter_tools/lib/src/build_system/targets/localizations.dart // 1. flutter_tools/lib/src/build_system/targets/localizations.dart
// 2. flutter_tools/test/general.shard/build_system/targets/localizations_test.dart // 2. flutter_tools/test/general.shard/build_system/targets/localizations_test.dart

13
packages/flutter_tools/test/commands.shard/hermetic/generate_localizations_test.dart
View File

@ -480,4 +480,17 @@ format: true
FileSystem: () => fileSystem, FileSystem: () => fileSystem,
ProcessManager: () => FakeProcessManager.any(), ProcessManager: () => FakeProcessManager.any(),
}); });
testUsingContext('throws error when unexpected positional argument is provided', () {
final GenerateLocalizationsCommand command = GenerateLocalizationsCommand(
fileSystem: fileSystem,
logger: logger,
artifacts: artifacts,
processManager: processManager,
);
expect(
() async => createTestCommandRunner(command).run(<String>['gen-l10n', '--synthetic-package', 'false']),
throwsToolExit(message: 'Unexpected positional argument "false".')
);
});
} }