From daed2108409c6c99e8032b17ad1b70c263567dcf Mon Sep 17 00:00:00 2001 From: LN Liberda Date: Wed, 27 Nov 2024 21:11:17 +0100 Subject: [PATCH] IWYU: add some missing includes failing with libstdc++13/14 (flutter/engine#56822) Fixes builds of engine with libstdc++13 and libstdc++14. *List which issues are fixed by this PR. You must list at least one issue.* closes https://github.com/flutter/flutter/issues/159513 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style --- engine/src/flutter/flow/paint_region.h | 1 + engine/src/flutter/fml/cpu_affinity.cc | 1 + engine/src/flutter/fml/cpu_affinity.h | 1 + engine/src/flutter/fml/synchronization/sync_switch.cc | 1 + engine/src/flutter/impeller/core/runtime_types.h | 1 + engine/src/flutter/impeller/geometry/path.h | 1 + engine/src/flutter/impeller/geometry/size.h | 1 + engine/src/flutter/impeller/typographer/rectangle_packer.cc | 1 + engine/src/flutter/impeller/typographer/rectangle_packer.h | 1 + engine/src/flutter/runtime/dart_service_isolate.h | 1 + engine/src/flutter/shell/platform/glfw/flutter_glfw.cc | 1 + .../src/flutter/third_party/tonic/filesystem/filesystem/file.h | 1 + engine/src/flutter/vulkan/vulkan_surface.h | 2 ++ 13 files changed, 14 insertions(+) diff --git a/engine/src/flutter/flow/paint_region.h b/engine/src/flutter/flow/paint_region.h index 52f29762f6..34b7ac1e9b 100644 --- a/engine/src/flutter/flow/paint_region.h +++ b/engine/src/flutter/flow/paint_region.h @@ -5,6 +5,7 @@ #ifndef FLUTTER_FLOW_PAINT_REGION_H_ #define FLUTTER_FLOW_PAINT_REGION_H_ +#include #include #include #include "flutter/fml/logging.h" diff --git a/engine/src/flutter/fml/cpu_affinity.cc b/engine/src/flutter/fml/cpu_affinity.cc index 0342c85f04..a580c9d04c 100644 --- a/engine/src/flutter/fml/cpu_affinity.cc +++ b/engine/src/flutter/fml/cpu_affinity.cc @@ -5,6 +5,7 @@ #include "flutter/fml/cpu_affinity.h" #include "flutter/fml/build_config.h" +#include #include #include #include diff --git a/engine/src/flutter/fml/cpu_affinity.h b/engine/src/flutter/fml/cpu_affinity.h index c1d8498e65..c644472965 100644 --- a/engine/src/flutter/fml/cpu_affinity.h +++ b/engine/src/flutter/fml/cpu_affinity.h @@ -5,6 +5,7 @@ #ifndef FLUTTER_FML_CPU_AFFINITY_H_ #define FLUTTER_FML_CPU_AFFINITY_H_ +#include #include #include #include diff --git a/engine/src/flutter/fml/synchronization/sync_switch.cc b/engine/src/flutter/fml/synchronization/sync_switch.cc index 463b6a08d7..9421e30e04 100644 --- a/engine/src/flutter/fml/synchronization/sync_switch.cc +++ b/engine/src/flutter/fml/synchronization/sync_switch.cc @@ -5,6 +5,7 @@ #include "flutter/fml/synchronization/sync_switch.h" #include +#include namespace fml { diff --git a/engine/src/flutter/impeller/core/runtime_types.h b/engine/src/flutter/impeller/core/runtime_types.h index b38d61b0eb..1d8ca60b29 100644 --- a/engine/src/flutter/impeller/core/runtime_types.h +++ b/engine/src/flutter/impeller/core/runtime_types.h @@ -6,6 +6,7 @@ #define FLUTTER_IMPELLER_CORE_RUNTIME_TYPES_H_ #include +#include #include #include #include diff --git a/engine/src/flutter/impeller/geometry/path.h b/engine/src/flutter/impeller/geometry/path.h index d81b3cb0ec..86263aa907 100644 --- a/engine/src/flutter/impeller/geometry/path.h +++ b/engine/src/flutter/impeller/geometry/path.h @@ -6,6 +6,7 @@ #define FLUTTER_IMPELLER_GEOMETRY_PATH_H_ #include +#include #include #include #include diff --git a/engine/src/flutter/impeller/geometry/size.h b/engine/src/flutter/impeller/geometry/size.h index b31970f1dd..2c609cddad 100644 --- a/engine/src/flutter/impeller/geometry/size.h +++ b/engine/src/flutter/impeller/geometry/size.h @@ -7,6 +7,7 @@ #include #include +#include #include #include #include diff --git a/engine/src/flutter/impeller/typographer/rectangle_packer.cc b/engine/src/flutter/impeller/typographer/rectangle_packer.cc index 3ec7464ff7..f9a7be86c5 100644 --- a/engine/src/flutter/impeller/typographer/rectangle_packer.cc +++ b/engine/src/flutter/impeller/typographer/rectangle_packer.cc @@ -5,6 +5,7 @@ #include "impeller/typographer/rectangle_packer.h" #include +#include #include #include "flutter/fml/logging.h" diff --git a/engine/src/flutter/impeller/typographer/rectangle_packer.h b/engine/src/flutter/impeller/typographer/rectangle_packer.h index 817bc6605e..d8b1e1caf3 100644 --- a/engine/src/flutter/impeller/typographer/rectangle_packer.h +++ b/engine/src/flutter/impeller/typographer/rectangle_packer.h @@ -9,6 +9,7 @@ #include "impeller/geometry/scalar.h" #include +#include namespace impeller { diff --git a/engine/src/flutter/runtime/dart_service_isolate.h b/engine/src/flutter/runtime/dart_service_isolate.h index a6fc32d429..439b49ce58 100644 --- a/engine/src/flutter/runtime/dart_service_isolate.h +++ b/engine/src/flutter/runtime/dart_service_isolate.h @@ -6,6 +6,7 @@ #define FLUTTER_RUNTIME_DART_SERVICE_ISOLATE_H_ #include +#include #include #include #include diff --git a/engine/src/flutter/shell/platform/glfw/flutter_glfw.cc b/engine/src/flutter/shell/platform/glfw/flutter_glfw.cc index b00bab8ced..b2cdd11aed 100644 --- a/engine/src/flutter/shell/platform/glfw/flutter_glfw.cc +++ b/engine/src/flutter/shell/platform/glfw/flutter_glfw.cc @@ -7,6 +7,7 @@ #include #include +#include #include #include #include diff --git a/engine/src/flutter/third_party/tonic/filesystem/filesystem/file.h b/engine/src/flutter/third_party/tonic/filesystem/filesystem/file.h index be83b0f952..0e1aece1fe 100644 --- a/engine/src/flutter/third_party/tonic/filesystem/filesystem/file.h +++ b/engine/src/flutter/third_party/tonic/filesystem/filesystem/file.h @@ -5,6 +5,7 @@ #ifndef FILESYSTEM_FILE_H_ #define FILESYSTEM_FILE_H_ +#include #include #include diff --git a/engine/src/flutter/vulkan/vulkan_surface.h b/engine/src/flutter/vulkan/vulkan_surface.h index 3455425c27..fafd90ab4b 100644 --- a/engine/src/flutter/vulkan/vulkan_surface.h +++ b/engine/src/flutter/vulkan/vulkan_surface.h @@ -5,6 +5,8 @@ #ifndef FLUTTER_VULKAN_VULKAN_SURFACE_H_ #define FLUTTER_VULKAN_VULKAN_SURFACE_H_ +#include + #include "flutter/fml/macros.h" #include "flutter/vulkan/procs/vulkan_handle.h" #include "third_party/skia/include/core/SkSize.h"