From db2ecf44864b9abd965af32b3d9e517f603e90ee Mon Sep 17 00:00:00 2001 From: Mehmet Fidanboylu Date: Wed, 29 Jul 2020 22:24:52 -0700 Subject: [PATCH] Expose certain functions used when rolling Flutter (#62529) --- dev/tools/update_icons.dart | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/dev/tools/update_icons.dart b/dev/tools/update_icons.dart index a83c24dc87..570743497b 100644 --- a/dev/tools/update_icons.dart +++ b/dev/tools/update_icons.dart @@ -174,17 +174,17 @@ void main(List args) { } final String newCodepointsString = newCodepointsFile.readAsStringSync(); - final Map newTokenPairMap = _stringToTokenPairMap(newCodepointsString); + final Map newTokenPairMap = stringToTokenPairMap(newCodepointsString); final String oldCodepointsString = oldCodepointsFile.readAsStringSync(); - final Map oldTokenPairMap = _stringToTokenPairMap(oldCodepointsString); + final Map oldTokenPairMap = stringToTokenPairMap(oldCodepointsString); _testIsMapSuperset(newTokenPairMap, oldTokenPairMap); final String iconClassFileData = iconClassFile.readAsStringSync(); stderr.writeln('Generating new token pairs.'); - final String newIconData = _regenerateIconsFile(iconClassFileData, newTokenPairMap); + final String newIconData = regenerateIconsFile(iconClassFileData, newTokenPairMap); if (argResults[_dryRunOption] as bool) { stdout.writeln(newIconData); @@ -204,7 +204,8 @@ ArgResults _handleArguments(List args) { return argParser.parse(args); } -Map _stringToTokenPairMap(String codepointData) { +// Do not make this method private as it is used by g3 roll. +Map stringToTokenPairMap(String codepointData) { final Iterable cleanData = LineSplitter.split(codepointData) .map((String line) => line.trim()) .where((String line) => line.isNotEmpty); @@ -222,7 +223,8 @@ Map _stringToTokenPairMap(String codepointData) { return pairs; } -String _regenerateIconsFile(String iconData, Map tokenPairMap) { +// Do not make this method private as it is used by g3 roll. +String regenerateIconsFile(String iconData, Map tokenPairMap) { final StringBuffer buf = StringBuffer(); bool generating = false; for (final String line in LineSplitter.split(iconData)) {