firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

delete Usage in doctor tests (#162646)

Browse Source 
Tiny delete op. Toward https://github.com/flutter/flutter/issues/150575

<details>

<summary> Pre-launch checklist </summary> 


- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

</details>


<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
Andrew Kolos 2025-02-04 10:32:06 -08:00 committed by GitHub
parent 53a21710cf
commit db9591cfbf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 24 additions and 97 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

111
packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart
View File

@ -21,7 +21,6 @@ import 'package:flutter_tools/src/device.dart';
import 'package:flutter_tools/src/doctor.dart';
import 'package:flutter_tools/src/doctor_validator.dart';
import 'package:flutter_tools/src/globals.dart' as globals;
import 'package:flutter_tools/src/reporting/reporting.dart';
import 'package:flutter_tools/src/version.dart';
import 'package:flutter_tools/src/vscode/vscode.dart';
import 'package:flutter_tools/src/vscode/vscode_validator.dart';
@ -205,85 +204,6 @@ void main() {
);
});
group('doctor usage params', () {
late TestUsage testUsage;
setUp(() {
testUsage = TestUsage();
});
testUsingContext(
'contains installed',
() async {
final Doctor doctor = Doctor(logger: logger, clock: const SystemClock());
await doctor.diagnose(verbose: false);
expect(testUsage.events.length, 3);
expect(
testUsage.events,
contains(const TestUsageEvent('doctor-result', 'PassingValidator', label: 'installed')),
);
},
overrides: <Type, Generator>{
DoctorValidatorsProvider: () => FakeDoctorValidatorsProvider(),
Usage: () => testUsage,
},
);
testUsingContext('contains installed and partial', () async {
await FakePassingDoctor(logger).diagnose(verbose: false);
expect(
testUsage.events,
unorderedEquals(<TestUsageEvent>[
const TestUsageEvent('doctor-result', 'PassingValidator', label: 'installed'),
const TestUsageEvent('doctor-result', 'PassingValidator', label: 'installed'),
const TestUsageEvent('doctor-result', 'PartialValidatorWithHintsOnly', label: 'partial'),
const TestUsageEvent('doctor-result', 'PartialValidatorWithErrors', label: 'partial'),
]),
);
}, overrides: <Type, Generator>{Usage: () => testUsage});
testUsingContext('contains installed, missing and partial', () async {
await FakeDoctor(logger).diagnose(verbose: false);
expect(
testUsage.events,
unorderedEquals(<TestUsageEvent>[
const TestUsageEvent('doctor-result', 'PassingValidator', label: 'installed'),
const TestUsageEvent('doctor-result', 'MissingValidator', label: 'missing'),
const TestUsageEvent('doctor-result', 'NotAvailableValidator', label: 'notAvailable'),
const TestUsageEvent('doctor-result', 'PartialValidatorWithHintsOnly', label: 'partial'),
const TestUsageEvent('doctor-result', 'PartialValidatorWithErrors', label: 'partial'),
]),
);
}, overrides: <Type, Generator>{Usage: () => testUsage});
testUsingContext(
'events for grouped validators are properly decomposed',
() async {
await FakeGroupedDoctor(logger).diagnose(verbose: false);
expect(
testUsage.events,
unorderedEquals(<TestUsageEvent>[
const TestUsageEvent('doctor-result', 'PassingGroupedValidator', label: 'installed'),
const TestUsageEvent('doctor-result', 'PassingGroupedValidator', label: 'installed'),
const TestUsageEvent('doctor-result', 'PassingGroupedValidator', label: 'installed'),
const TestUsageEvent('doctor-result', 'MissingGroupedValidator', label: 'missing'),
]),
);
},
overrides: <Type, Generator>{Usage: () => testUsage},
);
testUsingContext('sending events can be skipped', () async {
await FakePassingDoctor(logger).diagnose(verbose: false, sendEvent: false);
expect(testUsage.events, isEmpty);
}, overrides: <Type, Generator>{Usage: () => testUsage});
});
group('doctor with fake validators', () {
testUsingContext(
'validate non-verbose output format for run without issues',
@ -516,18 +436,24 @@ void main() {
});
group('doctor diagnosis wrapper', () {
late TestUsage testUsage;
late FakeAnalytics analytics;
late BufferLogger logger;
setUp(() {
testUsage = TestUsage();
analytics = getInitializedFakeAnalyticsInstance(
fs: fs,
fakeFlutterVersion: FakeFlutterVersion(),
);
logger = BufferLogger.test();
});
testUsingContext(
'PII separated, events only sent once',
() async {
final Doctor fakeDoctor = FakePiiDoctor(logger);
final DateTime fakeDate = DateTime(1995, 3, 3);
final SystemClock systemClock = SystemClock.fixed(fakeDate);
final Doctor fakeDoctor = FakePiiDoctor(logger, clock: systemClock);
final DoctorText doctorText = DoctorText(logger, doctor: fakeDoctor);
const String expectedPiiText =
'[✓] PII Validator [0ms]\n'
@ -549,24 +475,25 @@ void main() {
expect(await doctorText.piiStrippedText, expectedPiiStrippedText);
// Only one event sent.
expect(testUsage.events, <TestUsageEvent>[
const TestUsageEvent('doctor-result', 'PiiValidator', label: 'installed'),
expect(analytics.sentEvents, <Event>[
Event.doctorValidatorResult(
validatorName: 'PII Validator',
result: 'installed',
partOfGroupedValidator: false,
doctorInvocationId: systemClock.now().millisecondsSinceEpoch,
),
]);
},
overrides: <Type, Generator>{AnsiTerminal: () => FakeTerminal(), Usage: () => testUsage},
overrides: <Type, Generator>{AnsiTerminal: () => FakeTerminal(), Analytics: () => analytics},
);
testUsingContext(
'without PII has same text and PII-stripped text',
() async {
testUsingContext('without PII has same text and PII-stripped text', () async {
final Doctor fakeDoctor = FakePassingDoctor(logger);
final DoctorText doctorText = DoctorText(logger, doctor: fakeDoctor);
final String piiText = await doctorText.text;
expect(piiText, isNotEmpty);
expect(piiText, await doctorText.piiStrippedText);
},
overrides: <Type, Generator>{Usage: () => testUsage},
);
});
});
testUsingContext(