firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed a bug related to AnimtedCrossFade. (#5730)

Browse Source 
Fixed a bug where the size of the AnimatedCrossFade would always
start from the size of the first child, irrespective of the
initial crossFadeState argument.
This commit is contained in:
Dragoș Tiselice 2016-09-02 16:41:09 -07:00 committed by GitHub
parent afc0550a67
commit dcda3d5ed8
2 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/widgets/animated_cross_fade.dart
View File

@ -106,6 +106,8 @@ class _AnimatedCrossFadeState extends State<AnimatedCrossFade> {
void initState() { void initState() {
super.initState(); super.initState();
_controller = new AnimationController(duration: config.duration); _controller = new AnimationController(duration: config.duration);
if (config.crossFadeState == CrossFadeState.showSecond)
_controller.value = 1.0;
_firstAnimation = _initAnimation(config.firstCurve, true); _firstAnimation = _initAnimation(config.firstCurve, true);
_secondAnimation = _initAnimation(config.secondCurve, false); _secondAnimation = _initAnimation(config.secondCurve, false);
} }

24
packages/flutter/test/widget/animated_cross_fade_test.dart
View File

@ -54,4 +54,28 @@ void main() {
expect(box.size.width, equals(150.0)); expect(box.size.width, equals(150.0));
expect(box.size.height, equals(150.0)); expect(box.size.height, equals(150.0));
}); });
testWidgets('AnimatedCrossFade test showSecond', (WidgetTester tester) async {
await tester.pumpWidget(
new Center(
child: new AnimatedCrossFade(
firstChild: new SizedBox(
width: 100.0,
height: 100.0
),
secondChild: new SizedBox(
width: 200.0,
height: 200.0
),
duration: const Duration(milliseconds: 200),
crossFadeState: CrossFadeState.showSecond
)
)
);
expect(find.byType(FadeTransition), findsNWidgets(2));
RenderBox box = tester.renderObject(find.byType(AnimatedCrossFade));
expect(box.size.width, equals(200.0));
expect(box.size.height, equals(200.0));
});
} }