From dd341d4295416f559b971fa58583a8efacfd376c Mon Sep 17 00:00:00 2001 From: Callum Moffat Date: Thu, 28 Sep 2023 09:05:10 -0400 Subject: [PATCH] Upload generated frame-request-pending stats (#135645) These values are generated since https://github.com/flutter/flutter/pull/135279, but I didn't know to add the new keys to this list to get them to upload. Part of https://github.com/flutter/flutter/issues/129150 --- dev/devicelab/lib/tasks/perf_tests.dart | 3 +++ dev/devicelab/test/perf_tests_test.dart | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/dev/devicelab/lib/tasks/perf_tests.dart b/dev/devicelab/lib/tasks/perf_tests.dart index 1dc73382bf..416b43cd37 100644 --- a/dev/devicelab/lib/tasks/perf_tests.dart +++ b/dev/devicelab/lib/tasks/perf_tests.dart @@ -1358,6 +1358,9 @@ const List _kCommonScoreKeys = [ '99th_percentile_picture_cache_memory', 'worst_picture_cache_memory', 'old_gen_gc_count', + 'average_frame_request_pending_latency', + '90th_percentile_frame_request_pending_latency', + '99th_percentile_frame_request_pending_latency' ]; /// Measures how long it takes to compile a Flutter app to JavaScript and how diff --git a/dev/devicelab/test/perf_tests_test.dart b/dev/devicelab/test/perf_tests_test.dart index 237cffb1c8..57a214cc8b 100644 --- a/dev/devicelab/test/perf_tests_test.dart +++ b/dev/devicelab/test/perf_tests_test.dart @@ -58,6 +58,9 @@ void main() { 'average_vsync_transitions_missed': 1, '90th_percentile_vsync_transitions_missed': 1, '99th_percentile_vsync_transitions_missed': 1, + 'average_frame_request_pending_latency': 0.1, + '90th_percentile_frame_request_pending_latency': 0.1, + '99th_percentile_frame_request_pending_latency': 0.1, }; const String resultFileName = 'fake_result'; void driveCallback(List arguments) { @@ -108,6 +111,9 @@ void main() { '90hz_frame_percentage': 0.4, '120hz_frame_percentage': 0.6, 'illegal_refresh_rate_frame_count': 10, + 'average_frame_request_pending_latency': 0.1, + '90th_percentile_frame_request_pending_latency': 0.1, + '99th_percentile_frame_request_pending_latency': 0.1, }; const String resultFileName = 'fake_result'; void driveCallback(List arguments) {