From dd437c7a604ba2180ff6fba40f52613593af4f04 Mon Sep 17 00:00:00 2001 From: Mouad Debbar Date: Thu, 12 Dec 2024 15:32:27 -0500 Subject: [PATCH] [web] Enable platform view benchmarks in Skwasm (#160186) Skwasm has support for platform views already. Let's enable those benchmarks. --- dev/benchmarks/macrobenchmarks/lib/web_benchmarks.dart | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/dev/benchmarks/macrobenchmarks/lib/web_benchmarks.dart b/dev/benchmarks/macrobenchmarks/lib/web_benchmarks.dart index d396ba63db..1fa13722d4 100644 --- a/dev/benchmarks/macrobenchmarks/lib/web_benchmarks.dart +++ b/dev/benchmarks/macrobenchmarks/lib/web_benchmarks.dart @@ -36,8 +36,6 @@ import 'src/web/recorder.dart'; typedef RecorderFactory = Recorder Function(); -const bool isSkwasm = bool.fromEnvironment('FLUTTER_WEB_USE_SKWASM'); - /// List of all benchmarks that run in the devicelab. /// /// When adding a new benchmark, add it to this map. Make sure that the name @@ -69,12 +67,8 @@ final Map benchmarks = { BenchMouseRegionGridHover.benchmarkName: () => BenchMouseRegionGridHover(), BenchMouseRegionMixedGridHover.benchmarkName: () => BenchMouseRegionMixedGridHover(), BenchWrapBoxScroll.benchmarkName: () => BenchWrapBoxScroll(), - if (!isSkwasm) ...{ - // Platform views are not yet supported with Skwasm. - // https://github.com/flutter/flutter/issues/126346 - BenchPlatformViewInfiniteScroll.benchmarkName: () => BenchPlatformViewInfiniteScroll.forward(), - BenchPlatformViewInfiniteScroll.benchmarkNameBackward: () => BenchPlatformViewInfiniteScroll.backward(), - }, + BenchPlatformViewInfiniteScroll.benchmarkName: () => BenchPlatformViewInfiniteScroll.forward(), + BenchPlatformViewInfiniteScroll.benchmarkNameBackward: () => BenchPlatformViewInfiniteScroll.backward(), BenchMaterial3Components.benchmarkName: () => BenchMaterial3Components(), BenchMaterial3Semantics.benchmarkName: () => BenchMaterial3Semantics(), BenchMaterial3ScrollSemantics.benchmarkName: () => BenchMaterial3ScrollSemantics(),