firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix:: trigger onTapOutside only if has focus (#136291)

Browse Source 
Adds new feat and fix to https://github.com/flutter/flutter/issues/134341
This commit is contained in:
Mairramer 2023-10-25 21:26:20 -03:00 committed by GitHub
parent 1c90ed8b64
commit de4e3d67a0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/widgets/editable_text.dart
View File

@ -4770,7 +4770,7 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
compositeCallback: _compositeCallback,
enabled: _hasInputConnection,
child: TextFieldTapRegion(
onTapOutside: widget.onTapOutside ?? _defaultOnTapOutside,
onTapOutside: _hasFocus ? widget.onTapOutside ?? _defaultOnTapOutside : null,
debugLabel: kReleaseMode ? null : 'EditableText',
child: MouseRegion(
cursor: widget.mouseCursor ?? SystemMouseCursors.text,

32
packages/flutter/test/material/text_form_field_test.dart
View File

@ -773,6 +773,7 @@ void main() {
children: <Widget>[
const Text('Outside'),
TextFormField(
autofocus: true,
onTapOutside: (PointerEvent event) {
tapOutsideCount += 1;
},
@ -793,6 +794,37 @@ void main() {
expect(tapOutsideCount, 3);
});
// Regression test for https://github.com/flutter/flutter/issues/134341.
testWidgetsWithLeakTracking('onTapOutside is not called upon tap outside when field is not focused', (WidgetTester tester) async {
int tapOutsideCount = 0;
await tester.pumpWidget(
MaterialApp(
home: Material(
child: Center(
child: Column(
children: <Widget>[
const Text('Outside'),
TextFormField(
onTapOutside: (PointerEvent event) {
tapOutsideCount += 1;
},
),
],
),
),
),
),
);
await tester.pump();
expect(tapOutsideCount, 0);
await tester.tap(find.byType(TextFormField));
await tester.tap(find.text('Outside'));
await tester.tap(find.text('Outside'));
await tester.tap(find.text('Outside'));
expect(tapOutsideCount, 0);
});
// Regression test for https://github.com/flutter/flutter/issues/54472.
testWidgetsWithLeakTracking('reset resets the text fields value to the initialValue', (WidgetTester tester) async {
await tester.pumpWidget(