From dfba1a80ac3d21f590cf9110b54b3a1b8e85792f Mon Sep 17 00:00:00 2001
From: Elliott Sprehn <esprehn@chromium.org>
Date: Thu, 8 Jan 2015 15:30:18 -0800
Subject: [PATCH] Prevent expandos on all SkyElements.

Expandos make v8 sad, lets not allow them.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/835353004
---
 examples/city-list/city-list.sky | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/examples/city-list/city-list.sky b/examples/city-list/city-list.sky
index 4306c93455..1d75dc2696 100644
--- a/examples/city-list/city-list.sky
+++ b/examples/city-list/city-list.sky
@@ -27,6 +27,9 @@ module.exports = {};
 </template>
 <script>
 module.exports.StateHeaderElement = class extends SkyElement {
+  created() {
+    this.state = "";
+  }
   set datum(datum) {
     this.state = datum.state;
   }
@@ -49,6 +52,9 @@ module.exports.StateHeaderElement = class extends SkyElement {
 </template>
 <script>
 module.exports.LetterHeaderElement = class extends SkyElement {
+  created() {
+    this.letter = "";
+  }
   set datum(datum) {
     this.letter = datum.letter;
   }
@@ -92,6 +98,10 @@ module.exports.LetterHeaderElement = class extends SkyElement {
 </template>
 <script>
 module.exports.CityItemElement = class extends SkyElement {
+  created() {
+    this.name = "";
+    this.population = "";
+  }
   set datum(datum) {
     this.name = datum.name;
     this.population = datum.population;
@@ -553,6 +563,7 @@ module.exports.CityItemElement = class extends SkyElement {
         this.date = null;
         this.month = null;
         this.views = null;
+        this.scrollerElement = null;
       }
 
       attached() {
@@ -566,7 +577,6 @@ module.exports.CityItemElement = class extends SkyElement {
           cityItem: 30
         });
 
-        this.dataLoaded = this.dataLoaded.bind(this);
         this.scrollerElement = this.shadowRoot.getElementById('scroller');
         this.scrollerElement.addEventListener('scroll',
             this.handleScroll.bind(this));
@@ -574,7 +584,7 @@ module.exports.CityItemElement = class extends SkyElement {
         var self = this;
         setTimeout(function() {
           self.domReady();
-          self.loader.maybeLoadMoreData(self.dataLoaded);
+          self.loader.maybeLoadMoreData(self.dataLoaded.bind(self));
         });
       }
 
@@ -591,7 +601,7 @@ module.exports.CityItemElement = class extends SkyElement {
         this.tiler.drawTiles(scrollFrame, data);
         var datum = scrollChanged ?
             this.tiler.getFirstVisibleDatum(scrollFrame) : null;
-        this.loader.maybeLoadMoreData(this.dataLoaded, datum);
+        this.loader.maybeLoadMoreData(this.dataLoaded.bind(this), datum);
       }
 
       dataLoaded(data, indexOffset) {