firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[flutter_tools] Remove package:image (#115848)

Browse Source 
* remove ciyaml targets

* remove screenshot_test and package:image

* update-packages

* remove TESTOWNERS entries
This commit is contained in:
Christopher Fujino 2022-11-22 13:49:57 -08:00 committed by GitHub
parent 14754a261f
commit dfdec8984f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 9 additions and 88 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
.ci.yaml
View File

@ -1919,15 +1919,6 @@ targets:
["devicelab", "android", "linux"]
task_name: integration_ui_keyboard_resize
- name: Linux_android integration_ui_screenshot
recipe: devicelab/devicelab_drone
presubmit: false
timeout: 60
properties:
tags: >
["devicelab", "android", "linux"]
task_name: integration_ui_screenshot
- name: Linux_android integration_ui_textfield
recipe: devicelab/devicelab_drone
presubmit: false
@ -3504,15 +3495,6 @@ targets:
["devicelab", "ios", "mac"]
task_name: integration_ui_ios_keyboard_resize
- name: Mac_ios integration_ui_ios_screenshot
recipe: devicelab/devicelab_drone
presubmit: false
timeout: 60
properties:
tags: >
["devicelab", "ios", "mac"]
task_name: integration_ui_ios_screenshot
- name: Mac_ios integration_ui_ios_textfield
recipe: devicelab/devicelab_drone
presubmit: false

2
TESTOWNERS
View File

@ -125,7 +125,6 @@
/dev/devicelab/bin/tasks/integration_ui_driver.dart @zanderso @flutter/tool
/dev/devicelab/bin/tasks/integration_ui_frame_number.dart @iskakaushik @flutter/engine
/dev/devicelab/bin/tasks/integration_ui_keyboard_resize.dart @zanderso @flutter/tool
/dev/devicelab/bin/tasks/integration_ui_screenshot.dart @zanderso @flutter/tool
/dev/devicelab/bin/tasks/integration_ui_textfield.dart @zanderso @flutter/tool
/dev/devicelab/bin/tasks/microbenchmarks.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/new_gallery__transition_perf.dart @zanderso @flutter/engine
@ -177,7 +176,6 @@
/dev/devicelab/bin/tasks/integration_ui_ios_driver.dart @zanderso @flutter/tool
/dev/devicelab/bin/tasks/integration_ui_ios_frame_number.dart @iskakaushik @flutter/engine
/dev/devicelab/bin/tasks/integration_ui_ios_keyboard_resize.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/integration_ui_ios_screenshot.dart @zanderso @flutter/tool
/dev/devicelab/bin/tasks/integration_ui_ios_textfield.dart @zanderso @flutter/tool
/dev/devicelab/bin/tasks/ios_app_with_extensions_test.dart @jmagman @flutter/tool
/dev/devicelab/bin/tasks/ios_content_validation_test.dart @jmagman @flutter/tool

4
dev/benchmarks/macrobenchmarks/pubspec.yaml
View File

@ -18,7 +18,7 @@ dependencies:
# flutter update-packages --force-upgrade
flutter_gallery_assets: 1.0.2
url_launcher: 6.1.6
url_launcher: 6.1.7
archive: 3.3.2 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
async: 2.10.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
@ -219,4 +219,4 @@ flutter:
fonts:
- asset: packages/flutter_gallery_assets/fonts/GalleryIcons.ttf
# PUBSPEC CHECKSUM: 29a2
# PUBSPEC CHECKSUM: b6a3

4
dev/bots/pubspec.yaml
View File

@ -31,7 +31,7 @@ dependencies:
equatable: 2.0.5 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
file: 6.1.4 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
frontend_server_client: 3.1.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
gcloud: 0.8.6 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
gcloud: 0.8.7 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
glob: 2.1.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
googleapis: 3.0.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
googleapis_auth: 1.3.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
@ -71,4 +71,4 @@ dependencies:
dev_dependencies:
test_api: 0.4.16
# PUBSPEC CHECKSUM: 0070
# PUBSPEC CHECKSUM: de71

4
dev/devicelab/pubspec.yaml
View File

@ -30,7 +30,7 @@ dependencies:
convert: 3.1.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
crypto: 3.0.2 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
equatable: 2.0.5 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
gcloud: 0.8.6 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
gcloud: 0.8.7 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
googleapis: 3.0.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
googleapis_auth: 1.3.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
http_parser: 4.0.2 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
@ -69,4 +69,4 @@ dev_dependencies:
watcher: 1.0.2 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
web_socket_channel: 2.2.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
# PUBSPEC CHECKSUM: 07df
# PUBSPEC CHECKSUM: cde0

4
dev/integration_tests/flutter_gallery/pubspec.yaml
View File

@ -11,7 +11,7 @@ dependencies:
intl: 0.17.0
connectivity: 3.0.6
string_scanner: 1.2.0
url_launcher: 6.1.6
url_launcher: 6.1.7
# This is listed as direct so it can be manually pinned
url_launcher_android: 6.0.17
cupertino_icons: 1.0.5
@ -276,4 +276,4 @@ flutter:
- asset: packages/flutter_gallery_assets/fonts/merriweather/Merriweather-Regular.ttf
- asset: packages/flutter_gallery_assets/fonts/merriweather/Merriweather-Light.ttf
# PUBSPEC CHECKSUM: 1c23
# PUBSPEC CHECKSUM: 4e24

8
dev/integration_tests/ui/pubspec.yaml
View File

@ -4,11 +4,7 @@ description: Flutter non-plugin UI integration tests.
environment:
sdk: ">=2.17.0-0 <3.0.0"
# The "image" dependency below seems to only be needed for test_driver/screenshot_test.dart
# It can probably be removed, see the comment in that file.
dependencies:
image: 3.2.2
flutter:
sdk: flutter
flutter_driver:
@ -43,7 +39,6 @@ dependencies:
node_preamble: 2.0.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
package_config: 2.1.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
path: 1.8.2 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
petitparser: 5.1.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
pool: 1.5.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
pub_semver: 2.1.3 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
shelf: 1.4.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
@ -66,7 +61,6 @@ dependencies:
web_socket_channel: 2.2.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
webdriver: 3.0.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
webkit_inspection_protocol: 1.2.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
xml: 6.2.2 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
yaml: 3.1.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
dev_dependencies:
@ -82,4 +76,4 @@ flutter:
assets:
- assets/foo.png
# PUBSPEC CHECKSUM: 321a
# PUBSPEC CHECKSUM: 691e

53
dev/integration_tests/ui/test_driver/screenshot_test.dart
View File

@ -1,53 +0,0 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// This test is used by devicelab, test "integration_ui_ios_screenshot".
// Its use of package:image is, at the time of writing, the only use of that
// package in this repository. If package:image is a problem, it is probably
// fine to just remove this test since the value of the test is probably not
// as much as the cost of the dependency.
import 'package:flutter_driver/flutter_driver.dart';
import 'package:image/image.dart';
import 'package:test/test.dart' hide TypeMatcher, isInstanceOf;
void main() {
group('FlutterDriver', () {
late FlutterDriver driver;
setUpAll(() async {
driver = await FlutterDriver.connect();
});
tearDownAll(() async {
await driver.close();
});
test('should take screenshot', () async {
final SerializableFinder toggleBtn = find.byValueKey('toggle');
// Cards use a magic background color that we look for in the screenshots.
final Matcher cardsAreVisible = contains(getColor(0xff, 0x01, 0x02));
await driver.waitFor(toggleBtn);
bool cardsShouldBeVisible = false;
Image? imageBefore = decodePng(await driver.screenshot());
for (int i = 0; i < 10; i += 1) {
await driver.tap(toggleBtn);
cardsShouldBeVisible = !cardsShouldBeVisible;
final Image? imageAfter = decodePng(await driver.screenshot());
if (cardsShouldBeVisible) {
expect(imageBefore?.data, isNot(cardsAreVisible));
expect(imageAfter?.data, cardsAreVisible);
} else {
expect(imageBefore?.data, cardsAreVisible);
expect(imageAfter?.data, isNot(cardsAreVisible));
}
imageBefore = imageAfter;
}
}, timeout: Timeout.none);
});
}