firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix renderName on RenderBlock and RenderParagraph.

Browse Source 
RenderBlock should indicate when something is an inline-block.
RenderParagraph should not print out RenderBlock.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/828433004
This commit is contained in:
Ojan Vafai 2015-01-08 17:14:17 -08:00
parent 89ec5d9f84
commit e185d614cc
7 changed files with 38 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/tests/clipping/background-opaque-clipped-gradients-expected.txt
View File

@ -2,7 +2,7 @@ layer at (0,0) size 800x600
RenderView {#document} at (0,0) size 800x600
layer at (0,0) size 800x238
RenderBlock {sky} at (0,0) size 800x238
RenderBlock (anonymous) at (0,0) size 800x38
RenderParagraph (anonymous) at (0,0) size 800x38
RenderText {#text} at (0,0) size 778x38
text run at (0,0) width 778: "Test passes if the image below shows nested green, blue and yellow squares with a dotted black"
text run at (0,19) width 59: "border."

8
engine/src/flutter/tests/clipping/canvas-rounded-corners-expected.txt
View File

@ -3,20 +3,20 @@ layer at (0,0) size 800x600
layer at (0,0) size 800x353
RenderBlock {sky} at (0,0) size 800x353
RenderBlock {h3} at (0,0) size 800x19
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 92x19
text run at (0,0) width 92: "It passes if:"
RenderBlock {ul} at (0,19) size 800x57
RenderBlock {li} at (0,0) size 800x19
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 511x19
text run at (0,0) width 511: "the canvas content has rounded corners (top-left and top-right)"
RenderBlock {li} at (0,19) size 800x19
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 457x19
text run at (0,0) width 457: "the 10px red border is visible around the canvas content"
RenderBlock {li} at (0,38) size 800x19
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 200x19
text run at (0,0) width 200: "gray border is not visible"
layer at (0,76) size 277x277

8
engine/src/flutter/tests/layout/ellipsis-expected.txt
View File

@ -4,18 +4,18 @@ layer at (0,0) size 800x94
RenderBlock {sky} at (0,0) size 800x94
layer at (0,0) size 56x69 clip at (3,3) size 50x63 scrollWidth 93
RenderBlock {div} at (0,0) size 56x69 [border: (3px solid #0000FF)]
RenderBlock (anonymous) at (3,3) size 50x19
RenderParagraph (anonymous) at (3,3) size 50x19
RenderText {#text} at (0,0) size 91x19
text run at (0,0) width 91: "These lines"
RenderBlock (anonymous) at (3,47) size 50x19
RenderParagraph (anonymous) at (3,47) size 50x19
RenderText {#text} at (0,0) size 94x19
text run at (0,0) width 94: "all ellipsize."
layer at (3,22) size 56x25 backgroundClip at (3,22) size 50x25 clip at (6,25) size 47x19 outlineClip at (3,3) size 50x63 scrollWidth 53
RenderBlock {p} at (3,22) size 56x25 [border: (3px solid #FF0000)]
RenderParagraph {p} at (3,22) size 56x25 [border: (3px solid #FF0000)]
RenderText {#text} at (3,3) size 54x19
text run at (3,3) width 54: "should"
layer at (0,69) size 56x25 clip at (3,72) size 50x19 scrollWidth 117
RenderBlock {p} at (0,69) size 56x25 [border: (3px solid #FF0000)]
RenderParagraph {p} at (0,69) size 56x25 [border: (3px solid #FF0000)]
RenderInline {span} at (0,0) size 117x19
RenderText {#text} at (3,3) size 117x19
text run at (3,3) width 117: "As should this."

16
engine/src/flutter/tests/lowlevel/abarth-expected.txt
View File

@ -6,36 +6,36 @@ layer at (0,0) size 800x600
RenderBlock {body} at (0,0) size 800x600 [bgcolor=#FFFFFF]
RenderBlock {div} at (0,0) size 800x265
RenderBlock {div} at (0,0) size 800x115
RenderBlock {div} at (15,15) size 770x49
RenderParagraph {div} at (15,15) size 770x49
RenderInline {a} at (0,0) size 242x48 [color=#333333]
RenderText {#text} at (528,0) size 242x48
text run at (528,0) width 242: "Adam Barth"
RenderBlock {div} at (15,64) size 770x36
RenderBlock {div} at (0,0) size 770x18
RenderParagraph {div} at (0,0) size 770x18
RenderText {#text} at (574,0) size 196x17
text run at (574,0) width 196: "Ph.D., M.S., Stanford, 2008"
RenderBlock {div} at (0,18) size 770x18
RenderParagraph {div} at (0,18) size 770x18
RenderText {#text} at (635,0) size 135x17
text run at (635,0) width 135: "B.A., Cornell, 2003"
RenderBlock {div} at (0,115) size 800x150
RenderBlock {div} at (0,19) size 800x28
RenderParagraph {div} at (0,19) size 800x28
RenderInline {a} at (0,0) size 93x17 [color=#333333]
RenderText {#text} at (692,5) size 93x17
text run at (692,5) width 93: "@adambarth"
RenderBlock {div} at (0,47) size 800x28
RenderParagraph {div} at (0,47) size 800x28
RenderInline {a} at (0,0) size 35x17 [color=#333333]
RenderText {#text} at (750,5) size 35x17
text run at (750,5) width 35: "Blink"
RenderBlock {div} at (0,75) size 800x28
RenderParagraph {div} at (0,75) size 800x28
RenderInline {a} at (0,0) size 74x17 [color=#333333]
RenderText {#text} at (711,5) size 74x17
text run at (711,5) width 74: "Chromium"
RenderBlock {div} at (0,103) size 800x28
RenderParagraph {div} at (0,103) size 800x28
RenderInline {a} at (0,0) size 87x17 [color=#333333]
RenderText {#text} at (698,5) size 87x17
text run at (698,5) width 87: "Publications"
layer at (686,582) size 114x18
RenderBlock (positioned) {div} at (686.19,582) size 113.81x18 [color=#333333]
RenderParagraph {div} at (686.19,582) size 113.81x18 [color=#333333]
RenderText {#text} at (3,3) size 73x12
text run at (3,3) width 73: "Photograph by "
RenderInline {a} at (0,0) size 36x12

2
engine/src/flutter/tests/lowlevel/hello-world-expected.txt
View File

@ -2,7 +2,7 @@ layer at (0,0) size 800x600
RenderView {#document} at (0,0) size 800x600
layer at (0,0) size 800x19
RenderBlock {foo} at (0,0) size 800x19
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 99x19
text run at (0,0) width 99: "Hello World!"

10
engine/src/flutter/tests/lowlevel/iframe-expected.txt
View File

@ -3,21 +3,21 @@ layer at (0,0) size 800x600
layer at (0,0) size 800x506
RenderBlock {sky} at (0,0) size 800x506
RenderBlock {div} at (0,0) size 800x228
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 76x19
text run at (0,0) width 76: "This is an"
RenderBlock (anonymous) at (0,209) size 800x19
RenderParagraph (anonymous) at (0,209) size 800x19
RenderText {#text} at (0,0) size 72x19
text run at (0,0) width 72: "element."
RenderBlock {div} at (0,228) size 800x200
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 99x19
text run at (0,0) width 99: "Placeholder."
RenderBlock {div} at (0,428) size 800x78
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 218x19
text run at (0,0) width 218: "Small iframe should render"
RenderBlock (anonymous) at (0,59) size 800x19
RenderParagraph (anonymous) at (0,59) size 800x19
RenderText {#text} at (0,0) size 76x19
text run at (0,0) width 76: "correctly."
layer at (0,19) size 340x190

30
engine/src/flutter/tests/lowlevel/scrollbar-expected.txt
View File

@ -5,63 +5,63 @@ layer at (0,0) size 800x400
layer at (0,0) size 800x400 scrollHeight 1500
RenderBlock {scroller} at (0,0) size 800x400
RenderBlock {div} at (0,0) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 10x19
text run at (0,0) width 10: "a"
RenderBlock {div} at (0,100) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 11x19
text run at (0,0) width 11: "b"
RenderBlock {div} at (0,200) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 9x19
text run at (0,0) width 9: "c"
RenderBlock {div} at (0,300) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 11x19
text run at (0,0) width 11: "d"
RenderBlock {div} at (0,400) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 10x19
text run at (0,0) width 10: "e"
RenderBlock {div} at (0,500) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 6x19
text run at (0,0) width 6: "f"
RenderBlock {div} at (0,600) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 11x19
text run at (0,0) width 11: "g"
RenderBlock {div} at (0,700) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 11x19
text run at (0,0) width 11: "h"
RenderBlock {div} at (0,800) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 5x19
text run at (0,0) width 5: "i"
RenderBlock {div} at (0,900) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 5x19
text run at (0,0) width 5: "j"
RenderBlock {div} at (0,1000) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 10x19
text run at (0,0) width 10: "k"
RenderBlock {div} at (0,1100) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 5x19
text run at (0,0) width 5: "l"
RenderBlock {div} at (0,1200) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 16x19
text run at (0,0) width 16: "m"
RenderBlock {div} at (0,1300) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 11x19
text run at (0,0) width 11: "n"
RenderBlock {div} at (0,1400) size 800x100
RenderBlock (anonymous) at (0,0) size 800x19
RenderParagraph (anonymous) at (0,0) size 800x19
RenderText {#text} at (0,0) size 10x19
text run at (0,0) width 10: "o"