From e20bff4d794457b73cfb97bab7652e4e106f6a2d Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Sat, 14 Oct 2017 11:29:37 -0700 Subject: [PATCH] Add benchmark score keys to the hot mode test report. (#12547) This is follow-up to be1467e0cdb233a528077f1db962c46f28bb5820. --- dev/devicelab/lib/tasks/hot_mode_tests.dart | 35 ++++++++++++++------- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/dev/devicelab/lib/tasks/hot_mode_tests.dart b/dev/devicelab/lib/tasks/hot_mode_tests.dart index 583dbd9705..03b5ffee82 100644 --- a/dev/devicelab/lib/tasks/hot_mode_tests.dart +++ b/dev/devicelab/lib/tasks/hot_mode_tests.dart @@ -77,16 +77,29 @@ TaskFunction createHotModeTest({ bool isPreviewDart2: false }) { }); final Map twoReloadsData = JSON.decode( benchmarkFile.readAsStringSync()); - return new TaskResult.success( { - 'hotReloadInitialDevFSSyncMilliseconds': twoReloadsData['hotReloadInitialDevFSSyncMilliseconds'][0], - 'hotRestartMillisecondsToFrame': twoReloadsData['hotRestartMillisecondsToFrame'][0], - 'hotReloadMillisecondsToFrame' : twoReloadsData['hotReloadMillisecondsToFrame'][0], - 'hotReloadDevFSSyncMilliseconds': twoReloadsData['hotReloadDevFSSyncMilliseconds'][0], - 'hotReloadFlutterReassembleMilliseconds': twoReloadsData['hotReloadFlutterReassembleMilliseconds'][0], - 'hotReloadVMReloadMilliseconds': twoReloadsData['hotReloadVMReloadMilliseconds'][0], - 'hotReloadDevFSSyncMillisecondsAfterChange': twoReloadsData['hotReloadDevFSSyncMilliseconds'][1], - 'hotReloadFlutterReassembleMillisecondsAfterChange': twoReloadsData['hotReloadFlutterReassembleMilliseconds'][1], - 'hotReloadVMReloadMillisecondsAfterChange': twoReloadsData['hotReloadVMReloadMilliseconds'][1] - }); + return new TaskResult.success( + { + 'hotReloadInitialDevFSSyncMilliseconds': twoReloadsData['hotReloadInitialDevFSSyncMilliseconds'][0], + 'hotRestartMillisecondsToFrame': twoReloadsData['hotRestartMillisecondsToFrame'][0], + 'hotReloadMillisecondsToFrame' : twoReloadsData['hotReloadMillisecondsToFrame'][0], + 'hotReloadDevFSSyncMilliseconds': twoReloadsData['hotReloadDevFSSyncMilliseconds'][0], + 'hotReloadFlutterReassembleMilliseconds': twoReloadsData['hotReloadFlutterReassembleMilliseconds'][0], + 'hotReloadVMReloadMilliseconds': twoReloadsData['hotReloadVMReloadMilliseconds'][0], + 'hotReloadDevFSSyncMillisecondsAfterChange': twoReloadsData['hotReloadDevFSSyncMilliseconds'][1], + 'hotReloadFlutterReassembleMillisecondsAfterChange': twoReloadsData['hotReloadFlutterReassembleMilliseconds'][1], + 'hotReloadVMReloadMillisecondsAfterChange': twoReloadsData['hotReloadVMReloadMilliseconds'][1], + }, + benchmarkScoreKeys: [ + 'hotReloadInitialDevFSSyncMilliseconds', + 'hotRestartMillisecondsToFrame', + 'hotReloadMillisecondsToFrame', + 'hotReloadDevFSSyncMilliseconds', + 'hotReloadFlutterReassembleMilliseconds', + 'hotReloadVMReloadMilliseconds', + 'hotReloadDevFSSyncMillisecondsAfterChange', + 'hotReloadFlutterReassembleMillisecondsAfterChange', + 'hotReloadVMReloadMillisecondsAfterChange', + ] + ); }; }