firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove outdated ignores (#108924)

Browse Source
This commit is contained in:
Michael Goderbauer 2022-08-03 16:37:05 -07:00 committed by GitHub
parent b972f872b8
commit e27a19e3f8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
12 changed files with 16 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/integration_tests/deferred_components_test/lib/main.dart
View File

@ -62,8 +62,6 @@ class MyHomePageState extends State<MyHomePage> {
// the placeholder text.
Future<void>.delayed(const Duration(milliseconds: 750), () {
setState(() {
// See https://github.com/dart-lang/sdk/issues/46894
// ignore: prefer_const_constructors
postLoadDisplayWidget = component1.LogoScreen();
});
});

3
dev/integration_tests/web/lib/stack_trace.dart
View File

@ -150,9 +150,8 @@ class StackFrameEquality implements Equality<StackFrame> {
e1.method == e2.method;
}
// TODO(dnfield): This ignore shouldn't be necessary, see https://github.com/dart-lang/sdk/issues/46477
@override
int hash(StackFrame e) { // ignore: avoid_renaming_method_parameters
int hash(StackFrame e) {
return Object.hash(e.number, e.packageScheme, e.package, e.packagePath, e.line, e.column, e.className, e.method);
}

3
dev/integration_tests/web_e2e_tests/test_driver/text_editing_integration.dart
View File

@ -234,14 +234,11 @@ void main() {
KeyboardEvent dispatchKeyboardEvent(
EventTarget target, String type, Map<String, dynamic> args) {
// ignore: implicit_dynamic_function
final Object jsKeyboardEvent = js_util.getProperty(window, 'KeyboardEvent') as Object;
final List<dynamic> eventArgs = <dynamic>[
type,
args,
];
// ignore: implicit_dynamic_function
final KeyboardEvent event = js_util.callConstructor(
jsKeyboardEvent, js_util.jsify(eventArgs) as List<dynamic>)
as KeyboardEvent;

2
packages/flutter_test/lib/src/binding.dart
View File

@ -325,7 +325,7 @@ abstract class TestWidgetsFlutterBinding extends BindingBase
}
@override
// ignore: MUST_CALL_SUPER
// ignore: must_call_super
void initLicenses() {
// Do not include any licenses, because we're a test, and the LICENSE file
// doesn't get generated for tests.

1
packages/flutter_test/lib/src/event_simulation.dart
View File

@ -36,7 +36,6 @@ String? _keyLabel(LogicalKeyboardKey key) {
return null;
}
// ignore: avoid_classes_with_only_static_members
/// A class that serves as a namespace for a bunch of keyboard-key generation
/// utilities.
class KeyEventSimulator {

2
packages/flutter_tools/lib/src/version.dart
View File

@ -100,7 +100,7 @@ class FlutterVersion {
String? _repositoryUrl;
String? get repositoryUrl {
final String _ = channel; // ignore: no_leading_underscores_for_local_identifiers
final String _ = channel;
return _repositoryUrl;
}

12
packages/flutter_tools/test/commands.shard/hermetic/custom_devices_test.dart
View File

@ -547,7 +547,7 @@ void main() {
'-w', '1',
'testhostname',
],
postBuildCommand: null, // ignore: avoid_redundant_argument_values
postBuildCommand: null,
installCommand: const <String>[
'scp',
'-r',
@ -637,7 +637,7 @@ void main() {
'-w', '1',
'192.168.178.1',
],
postBuildCommand: null, // ignore: avoid_redundant_argument_values
postBuildCommand: null,
installCommand: const <String>[
'scp',
'-r',
@ -727,7 +727,7 @@ void main() {
'-w', '1',
'::1',
],
postBuildCommand: null, // ignore: avoid_redundant_argument_values
postBuildCommand: null,
installCommand: const <String>[
'scp',
'-r',
@ -821,7 +821,7 @@ void main() {
'-w', '1',
'testhostname',
],
postBuildCommand: null, // ignore: avoid_redundant_argument_values
postBuildCommand: null,
installCommand: <String>[
'scp',
'-r',
@ -901,7 +901,7 @@ void main() {
'-w', '1',
'testhostname',
],
postBuildCommand: null, // ignore: avoid_redundant_argument_values
postBuildCommand: null,
installCommand: const <String>[
'scp',
'-r',
@ -1226,7 +1226,7 @@ void main() {
'testhostname',
],
pingSuccessRegex: RegExp(r'[<=]\d+ms'),
postBuildCommand: null, // ignore: avoid_redundant_argument_values
postBuildCommand: null,
installCommand: const <String>[
'scp',
'-r',

1
packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart
View File

@ -251,7 +251,6 @@ void main() {
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class ThrowingScreenshotDevice extends ScreenshotDevice {
@override
Future<LaunchResult> startApp(

12
packages/flutter_tools/test/general.shard/android/android_workflow_test.dart
View File

@ -38,7 +38,7 @@ void main() {
testWithoutContext('AndroidWorkflow handles a null AndroidSDK', () {
final AndroidWorkflow androidWorkflow = AndroidWorkflow(
featureFlags: TestFeatureFlags(),
androidSdk: null, // ignore: avoid_redundant_argument_values
androidSdk: null,
operatingSystemUtils: FakeOperatingSystemUtils(),
);
@ -391,7 +391,7 @@ Review licenses that have not been accepted (y/N)?
);
final AndroidValidator androidValidator = AndroidValidator(
androidStudio: null, // ignore: avoid_redundant_argument_values
androidStudio: null,
androidSdk: sdk,
fileSystem: fileSystem,
logger: logger,
@ -439,7 +439,7 @@ Review licenses that have not been accepted (y/N)?
..directory = fileSystem.directory('/foo/bar');
final AndroidValidator androidValidator = AndroidValidator(
androidStudio: null, // ignore: avoid_redundant_argument_values
androidStudio: null,
androidSdk: sdk,
fileSystem: fileSystem,
logger: logger,
@ -488,7 +488,7 @@ Review licenses that have not been accepted (y/N)?
final ValidationResult validationResult = await AndroidValidator(
androidSdk: sdk,
androidStudio: null, // ignore: avoid_redundant_argument_values
androidStudio: null,
fileSystem: fileSystem,
logger: logger,
platform: FakePlatform()..environment = <String, String>{'HOME': '/home/me', 'JAVA_HOME': 'home/java'},
@ -510,8 +510,8 @@ Review licenses that have not been accepted (y/N)?
testWithoutContext('Mentions `flutter config --android-sdk if user has no AndroidSdk`', () async {
final ValidationResult validationResult = await AndroidValidator(
androidSdk: null, // ignore: avoid_redundant_argument_values
androidStudio: null, // ignore: avoid_redundant_argument_values
androidSdk: null,
androidStudio: null,
fileSystem: fileSystem,
logger: logger,
platform: FakePlatform()..environment = <String, String>{'HOME': '/home/me', 'JAVA_HOME': 'home/java'},

1
packages/flutter_tools/test/general.shard/base/logger_test.dart
View File

@ -566,7 +566,6 @@ void main() {
outputStdout().join('\n'),
'$message' // initial message
'${" " * 4}${" " * 8}' // margin (4) and space for the time at the end (8)
// ignore: missing_whitespace_between_adjacent_strings
'$a' // first tick
'$blankLine' // clearing the line
'Rude Interrupting Cow\n' // message

2
packages/flutter_tools/test/general.shard/device_port_forwarder_test.dart
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:io' as io; // ignore: dart_io_import
import 'dart:io' as io;
import 'package:flutter_tools/src/base/io.dart';
import 'package:flutter_tools/src/device_port_forwarder.dart';
import 'package:test/fake.dart';

2
packages/flutter_tools/test/general.shard/web/devfs_web_test.dart
View File

@ -4,8 +4,6 @@
// @dart = 2.8
// ignore_for_file: avoid_redundant_argument_values
import 'dart:io' hide Directory, File;
import 'package:flutter_tools/src/artifacts.dart';