diff --git a/dev/bots/test/common.dart b/dev/bots/test/common.dart index 8348fa724b..d6e0e1f5f7 100644 --- a/dev/bots/test/common.dart +++ b/dev/bots/test/common.dart @@ -13,7 +13,7 @@ export 'package:test/test.dart' hide TypeMatcher, isInstanceOf; // TODO(ianh): Remove this file once https://github.com/dart-lang/matcher/issues/98 is fixed /// A matcher that compares the type of the actual value to the type argument T. -Matcher isInstanceOf() => test_package.TypeMatcher(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 +Matcher isInstanceOf() => test_package.TypeMatcher(); void tryToDelete(Directory directory) { // This should not be necessary, but it turns out that diff --git a/dev/devicelab/test/common.dart b/dev/devicelab/test/common.dart index 75cf5c36eb..53b057772e 100644 --- a/dev/devicelab/test/common.dart +++ b/dev/devicelab/test/common.dart @@ -11,4 +11,4 @@ export 'package:test/test.dart' hide TypeMatcher, isInstanceOf; // TODO(ianh): Remove this file once https://github.com/dart-lang/matcher/issues/98 is fixed /// A matcher that compares the type of the actual value to the type argument T. -Matcher isInstanceOf() => test_package.TypeMatcher(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 +Matcher isInstanceOf() => test_package.TypeMatcher(); diff --git a/dev/integration_tests/android_semantics_testing/lib/src/flutter_test_alternative.dart b/dev/integration_tests/android_semantics_testing/lib/src/flutter_test_alternative.dart index 55d44ba91e..9c93c31106 100644 --- a/dev/integration_tests/android_semantics_testing/lib/src/flutter_test_alternative.dart +++ b/dev/integration_tests/android_semantics_testing/lib/src/flutter_test_alternative.dart @@ -11,4 +11,4 @@ import 'package:test/test.dart' as test_package show TypeMatcher; export 'package:test/test.dart' hide TypeMatcher, isInstanceOf; /// A matcher that compares the type of the actual value to the type argument T. -Matcher isInstanceOf() => test_package.TypeMatcher(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 +Matcher isInstanceOf() => test_package.TypeMatcher(); diff --git a/packages/flutter/test/flutter_test_alternative.dart b/packages/flutter/test/flutter_test_alternative.dart index 55d44ba91e..9c93c31106 100644 --- a/packages/flutter/test/flutter_test_alternative.dart +++ b/packages/flutter/test/flutter_test_alternative.dart @@ -11,4 +11,4 @@ import 'package:test/test.dart' as test_package show TypeMatcher; export 'package:test/test.dart' hide TypeMatcher, isInstanceOf; /// A matcher that compares the type of the actual value to the type argument T. -Matcher isInstanceOf() => test_package.TypeMatcher(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 +Matcher isInstanceOf() => test_package.TypeMatcher(); diff --git a/packages/flutter/test/material/reorderable_list_test.dart b/packages/flutter/test/material/reorderable_list_test.dart index 354277d6e8..bc21f799c0 100644 --- a/packages/flutter/test/material/reorderable_list_test.dart +++ b/packages/flutter/test/material/reorderable_list_test.dart @@ -914,7 +914,6 @@ Future longPressDrag(WidgetTester tester, Offset start, Offset end) async class _Stateful extends StatefulWidget { // Ignoring the preference for const constructors because we want to test with regular non-const instances. - // ignore:prefer_const_constructors // ignore:prefer_const_constructors_in_immutables _Stateful({Key key}) : super(key: key); diff --git a/packages/flutter/test/painting/flutter_logo_test.dart b/packages/flutter/test/painting/flutter_logo_test.dart index 5591697306..9d87e0d0a1 100644 --- a/packages/flutter/test/painting/flutter_logo_test.dart +++ b/packages/flutter/test/painting/flutter_logo_test.dart @@ -7,7 +7,6 @@ import 'package:flutter/painting.dart'; void main() { // Here and below, see: https://github.com/dart-lang/sdk/issues/26980 - // ignore: prefer_const_constructors final FlutterLogoDecoration start = FlutterLogoDecoration( lightColor: const Color(0xFF000000), darkColor: const Color(0xFFFFFFFF), @@ -16,7 +15,6 @@ void main() { margin: const EdgeInsets.all(10.0), ); - // ignore: prefer_const_constructors final FlutterLogoDecoration end = FlutterLogoDecoration( lightColor: const Color(0xFFFFFFFF), darkColor: const Color(0xFF000000), diff --git a/packages/flutter_driver/test/common.dart b/packages/flutter_driver/test/common.dart index efc4cbdc70..e462f69656 100644 --- a/packages/flutter_driver/test/common.dart +++ b/packages/flutter_driver/test/common.dart @@ -13,7 +13,7 @@ export 'package:test/test.dart' hide TypeMatcher, isInstanceOf; // TODO(ianh): Clean this up once https://github.com/dart-lang/matcher/issues/98 is fixed /// A matcher that compares the type of the actual value to the type argument T. -Matcher isInstanceOf() => test_package.TypeMatcher(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 +Matcher isInstanceOf() => test_package.TypeMatcher(); void tryToDelete(Directory directory) { // This should not be necessary, but it turns out that diff --git a/packages/flutter_test/lib/src/matchers.dart b/packages/flutter_test/lib/src/matchers.dart index d348d80157..231cce33b9 100644 --- a/packages/flutter_test/lib/src/matchers.dart +++ b/packages/flutter_test/lib/src/matchers.dart @@ -194,7 +194,7 @@ final Matcher isAssertionError = isInstanceOf(); /// A matcher that compares the type of the actual value to the type argument T. // TODO(ianh): Remove this once https://github.com/dart-lang/matcher/issues/98 is fixed -Matcher isInstanceOf() => test_package.TypeMatcher(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 +Matcher isInstanceOf() => test_package.TypeMatcher(); /// Asserts that two [double]s are equal, within some tolerated error. /// diff --git a/packages/flutter_tools/test/src/common.dart b/packages/flutter_tools/test/src/common.dart index 2424667b75..88298aa51f 100644 --- a/packages/flutter_tools/test/src/common.dart +++ b/packages/flutter_tools/test/src/common.dart @@ -20,7 +20,7 @@ export 'package:test/test.dart' hide TypeMatcher, isInstanceOf; // Defines a 'pa /// A matcher that compares the type of the actual value to the type argument T. // TODO(ianh): Remove this once https://github.com/dart-lang/matcher/issues/98 is fixed -Matcher isInstanceOf() => test_package.TypeMatcher(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 +Matcher isInstanceOf() => test_package.TypeMatcher(); void tryToDelete(Directory directory) { // This should not be necessary, but it turns out that diff --git a/packages/fuchsia_remote_debug_protocol/test/common.dart b/packages/fuchsia_remote_debug_protocol/test/common.dart index 55d44ba91e..9c93c31106 100644 --- a/packages/fuchsia_remote_debug_protocol/test/common.dart +++ b/packages/fuchsia_remote_debug_protocol/test/common.dart @@ -11,4 +11,4 @@ import 'package:test/test.dart' as test_package show TypeMatcher; export 'package:test/test.dart' hide TypeMatcher, isInstanceOf; /// A matcher that compares the type of the actual value to the type argument T. -Matcher isInstanceOf() => test_package.TypeMatcher(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 +Matcher isInstanceOf() => test_package.TypeMatcher();