firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Increase code coverage for RenderLayer::hitTestLayer.

Browse Source 
Add tests for the NormalFlowChildren and transforms code paths.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/926823004
This commit is contained in:
Ojan Vafai 2015-02-18 16:07:35 -08:00
parent 34f90cea4b
commit e72b889e5e
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/tests/layout/document-elementFromPoint-expected.txt
View File

@ -2,7 +2,9 @@ CONSOLE: unittest-suite-wait-for-done
CONSOLE: PASS: should hit test CONSOLE: PASS: should hit test
CONSOLE: PASS: should hit test child and parent CONSOLE: PASS: should hit test child and parent
CONSOLE: PASS: should hit test child with layered parent CONSOLE: PASS: should hit test child with layered parent
CONSOLE: PASS: should hit test transformed child
CONSOLE: PASS: should hit test canvas
CONSOLE: CONSOLE:
CONSOLE: All 3 tests passed. CONSOLE: All 5 tests passed.
CONSOLE: unittest-suite-success CONSOLE: unittest-suite-success
DONE DONE

12
engine/src/flutter/tests/layout/document-elementFromPoint.sky
View File

@ -4,11 +4,13 @@ foo, parent { width: 100px; height: 100px; background: blue; }
bar { width: 100px; height: 100px; background: purple; } bar { width: 100px; height: 100px; background: purple; }
parent { display: paragraph; } parent { display: paragraph; }
child { background: salmon; } child { background: salmon; }
canvas { height: 50px; background-color: pink; }
</style> </style>
<foo /><bar /> <foo /><bar />
<parent> <parent>
<child>Foo bar</child> <child>Foo bar</child>
</parent> </parent>
<canvas />
<script> <script>
import "../resources/third_party/unittest/unittest.dart"; import "../resources/third_party/unittest/unittest.dart";
import "../resources/unit.dart"; import "../resources/unit.dart";
@ -48,6 +50,16 @@ void main() {
document.querySelector('parent').style.setProperty("transform", "translate3d(0, 0, 0)"); document.querySelector('parent').style.setProperty("transform", "translate3d(0, 0, 0)");
hitTestWithChildren(); hitTestWithChildren();
}); });
test("should hit test transformed child", () {
document.querySelector('child').style.setProperty("transform", "translate3d(100px, 0, 0)");
expect(document.elementFromPoint(50, 210).tagName, equals('parent'));
expect(document.elementFromPoint(150, 210).tagName, equals('child'));
});
test("should hit test canvas", () {
expect(document.elementFromPoint(50, 310).tagName, equals('canvas'));
});
} }
</script> </script>
</sky> </sky>