From e7f9bcba2d22bd337210ceb47a193287a48b36e4 Mon Sep 17 00:00:00 2001 From: Swiftaxe Date: Mon, 16 Aug 2021 18:29:19 +0200 Subject: [PATCH] Removed no-shuffle tag and fixed leak in debug_test.dart (#88268) Co-authored-by: Alexander Dahlberg The TapGestureRecognizer in the test named 'TapGestureRecognizer _sentTapDown toString' was not disposed, which was breaking a couple of other tests. This worked fine when not shuffling the tests as the test was executed last. --- packages/flutter/test/gestures/debug_test.dart | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/flutter/test/gestures/debug_test.dart b/packages/flutter/test/gestures/debug_test.dart index 9aa34e1470..c5b89d421e 100644 --- a/packages/flutter/test/gestures/debug_test.dart +++ b/packages/flutter/test/gestures/debug_test.dart @@ -2,12 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// TODO(gspencergoog): Remove this tag once this test's state leaks/test -// dependencies have been fixed. -// https://github.com/flutter/flutter/issues/85160 -// Fails with "flutter test --test-randomize-ordering-seed=123" -@Tags(['no-shuffle']) - import 'package:flutter/foundation.dart'; import 'package:flutter/gestures.dart'; import 'package:flutter_test/flutter_test.dart'; @@ -160,5 +154,7 @@ void main() { tap.addPointer(event); tap.didExceedDeadline(); expect(tap.toString(), equalsIgnoringHashCodes('TapGestureRecognizer#00000(state: possible, button: 1, sent tap down)')); + GestureBinding.instance!.gestureArena.close(1); + tap.dispose(); }); }