firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Try fixing web tool tests on windows (#78386)

Browse Source
This commit is contained in:
Anna Gringauze 2021-03-17 22:13:13 -07:00 committed by GitHub
parent d777758036
commit e8c3ce6bd1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dev/try_builders.json
View File

@ -754,7 +754,8 @@
"name": "Windows web_tool_tests", "name": "Windows web_tool_tests",
"repo": "flutter", "repo": "flutter",
"task_name": "win_web_tool_tests", "task_name": "win_web_tool_tests",
"enabled": false "enabled": true,
"run_if": ["dev/**", "packages/flutter_tools/**", "bin/**"]
} }
] ]
} }

3
packages/flutter_tools/lib/src/isolated/devfs_web.dart
View File

@ -452,7 +452,8 @@ class WebAssetServer implements AssetReader {
} }
/// Tear down the http server running. /// Tear down the http server running.
Future<void> dispose() { Future<void> dispose() async {
await dwds?.stop();
return _httpServer.close(); return _httpServer.close();
} }

3
packages/flutter_tools/lib/src/web/chrome.dart
View File

@ -173,7 +173,8 @@ class ChromiumLauncher {
final String chromeExecutable = _browserFinder(_platform, _fileSystem); final String chromeExecutable = _browserFinder(_platform, _fileSystem);
if (_logger.isVerbose) { if (_logger.isVerbose && !_platform.isWindows) {
// Note: --version is not supported on windows.
final ProcessResult versionResult = await _processManager.run(<String>[chromeExecutable, '--version']); final ProcessResult versionResult = await _processManager.run(<String>[chromeExecutable, '--version']);
_logger.printTrace('Using ${versionResult.stdout}'); _logger.printTrace('Using ${versionResult.stdout}');
} }

3
packages/flutter_tools/test/web.shard/debugger_stepping_web_test.dart
View File

@ -4,6 +4,7 @@
// @dart = 2.8 // @dart = 2.8
@Timeout(Duration(minutes: 3))
import 'package:file/file.dart'; import 'package:file/file.dart';
import '../integration.shard/test_data/stepping_project.dart'; import '../integration.shard/test_data/stepping_project.dart';
@ -48,7 +49,7 @@ void main() {
reason: 'After $i steps, debugger should stop at $expectedLine but stopped at $actualLine' reason: 'After $i steps, debugger should stop at $expectedLine but stopped at $actualLine'
); );
} }
}, skip: platform.isWindows); // https://github.com/flutter/flutter/issues/70486 });
tearDown(() async { tearDown(() async {
await flutter.stop(); await flutter.stop();

3
packages/flutter_tools/test/web.shard/expression_evaluation_web_test.dart
View File

@ -4,6 +4,7 @@
// @dart = 2.8 // @dart = 2.8
@Timeout(Duration(minutes: 3))
import 'package:file/file.dart'; import 'package:file/file.dart';
import 'package:matcher/matcher.dart'; import 'package:matcher/matcher.dart';
import 'package:vm_service/vm_service.dart'; import 'package:vm_service/vm_service.dart';
@ -168,7 +169,7 @@ void batch2() {
await breakInMethod(_flutter); await breakInMethod(_flutter);
await evaluateComplexExpressions(_flutter); await evaluateComplexExpressions(_flutter);
await cleanProject(); await cleanProject();
}, skip: 'https://github.com/dart-lang/sdk/issues/41480'); });
} }
Future<void> failToEvaluateExpression(FlutterTestDriver flutter) async { Future<void> failToEvaluateExpression(FlutterTestDriver flutter) async {

1
packages/flutter_tools/test/web.shard/hot_reload_web_test.dart
View File

@ -4,6 +4,7 @@
// @dart = 2.8 // @dart = 2.8
@Timeout(Duration(minutes: 3))
import 'dart:async'; import 'dart:async';
import 'package:file/file.dart'; import 'package:file/file.dart';

1
packages/flutter_tools/test/web.shard/web_run_test.dart
View File

@ -4,6 +4,7 @@
// @dart = 2.8 // @dart = 2.8
@Timeout(Duration(minutes: 3))
import 'package:file/file.dart'; import 'package:file/file.dart';
import 'package:flutter_tools/src/base/file_system.dart'; import 'package:flutter_tools/src/base/file_system.dart';