firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix some tests now that the isMultiline flag is added to values (#37328)

Browse Source
This commit is contained in:
Yegor 2019-08-01 07:33:20 -07:00 committed by GitHub
parent e6dc6a8b5f
commit ea32385162
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/flutter/test/widgets/custom_painter_test.dart
View File

@ -419,8 +419,7 @@ void _defineTests() {
inMutuallyExclusiveGroup: true, inMutuallyExclusiveGroup: true,
header: true, header: true,
obscured: true, obscured: true,
// TODO(mdebbar): Uncomment after https://github.com/flutter/engine/pull/9894 multiline: true,
//multiline: true,
scopesRoute: true, scopesRoute: true,
namesRoute: true, namesRoute: true,
image: true, image: true,
@ -433,10 +432,7 @@ void _defineTests() {
List<SemanticsFlag> flags = SemanticsFlag.values.values.toList(); List<SemanticsFlag> flags = SemanticsFlag.values.values.toList();
// [SemanticsFlag.hasImplicitScrolling] isn't part of [SemanticsProperties] // [SemanticsFlag.hasImplicitScrolling] isn't part of [SemanticsProperties]
// therefore it has to be removed. // therefore it has to be removed.
flags flags.remove(SemanticsFlag.hasImplicitScrolling);
// TODO(mdebbar): Remove this line after https://github.com/flutter/engine/pull/9894
..remove(SemanticsFlag.isMultiline)
..remove(SemanticsFlag.hasImplicitScrolling);
TestSemantics expectedSemantics = TestSemantics.root( TestSemantics expectedSemantics = TestSemantics.root(
children: <TestSemantics>[ children: <TestSemantics>[
TestSemantics.rootChild( TestSemantics.rootChild(
@ -471,8 +467,7 @@ void _defineTests() {
inMutuallyExclusiveGroup: true, inMutuallyExclusiveGroup: true,
header: true, header: true,
obscured: true, obscured: true,
// TODO(mdebbar): Uncomment after https://github.com/flutter/engine/pull/9894 multiline: true,
//multiline: true,
scopesRoute: true, scopesRoute: true,
namesRoute: true, namesRoute: true,
image: true, image: true,
@ -484,10 +479,7 @@ void _defineTests() {
flags = SemanticsFlag.values.values.toList(); flags = SemanticsFlag.values.values.toList();
// [SemanticsFlag.hasImplicitScrolling] isn't part of [SemanticsProperties] // [SemanticsFlag.hasImplicitScrolling] isn't part of [SemanticsProperties]
// therefore it has to be removed. // therefore it has to be removed.
flags flags.remove(SemanticsFlag.hasImplicitScrolling);
// TODO(mdebbar): Remove this line after https://github.com/flutter/engine/pull/9894
..remove(SemanticsFlag.isMultiline)
..remove(SemanticsFlag.hasImplicitScrolling);
expectedSemantics = TestSemantics.root( expectedSemantics = TestSemantics.root(
children: <TestSemantics>[ children: <TestSemantics>[

5
packages/flutter/test/widgets/semantics_test.dart
View File

@ -479,8 +479,7 @@ void main() {
inMutuallyExclusiveGroup: true, inMutuallyExclusiveGroup: true,
header: true, header: true,
obscured: true, obscured: true,
// TODO(mdebbar): Uncomment after https://github.com/flutter/engine/pull/9894 multiline: true,
//multiline: true,
scopesRoute: true, scopesRoute: true,
namesRoute: true, namesRoute: true,
image: true, image: true,
@ -489,8 +488,6 @@ void main() {
); );
final List<SemanticsFlag> flags = SemanticsFlag.values.values.toList(); final List<SemanticsFlag> flags = SemanticsFlag.values.values.toList();
flags flags
// TODO(mdebbar): Remove this line after https://github.com/flutter/engine/pull/9894
..remove(SemanticsFlag.isMultiline)
..remove(SemanticsFlag.hasToggledState) ..remove(SemanticsFlag.hasToggledState)
..remove(SemanticsFlag.isToggled) ..remove(SemanticsFlag.isToggled)
..remove(SemanticsFlag.hasImplicitScrolling); ..remove(SemanticsFlag.hasImplicitScrolling);