firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix infinite loop in sky_tool listen if you didn’t specify —local-build

Browse Source
This commit is contained in:
Ian Fischer 2015-08-27 15:29:26 -07:00
parent e30b436d1a
commit ec503ea9b8
1 changed files with 41 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/flutter/lib/sky_tool
View File

@ -632,20 +632,19 @@ class StartListening(object):
] ]
subprocess.check_call(cmd) subprocess.check_call(cmd)
if not args.local_build: if args.local_build:
# Currently sending to iOS only works if you are building Sky locally # Currently sending to iOS only works if you are building Sky locally
# since we aren't shipping the sky_snapshot binary yet. # since we aren't shipping the sky_snapshot binary yet.
continue
# Build the snapshot # Check if we can make a snapshot
sky_snapshot_path = None
if args.ios_sim_build_available: if args.ios_sim_build_available:
sky_snapshot_path = os.path.join(args.sky_src_path, args.ios_sim_debug_build_path, 'clang_x64', 'sky_snapshot') sky_snapshot_path = os.path.join(args.sky_src_path, args.ios_sim_debug_build_path, 'clang_x64', 'sky_snapshot')
elif args.ios_build_available: elif args.ios_build_available:
sky_snapshot_path = os.path.join(args.sky_src_path, args.ios_debug_build_path, 'clang_x64', 'sky_snapshot') sky_snapshot_path = os.path.join(args.sky_src_path, args.ios_debug_build_path, 'clang_x64', 'sky_snapshot')
else:
# If there is no build available, we can't make a snapshot
continue
if sky_snapshot_path is not None:
# If we can make a snapshot, do so and then send it to running iOS instances
cmd = [ cmd = [
sky_snapshot_path, sky_snapshot_path,
'--package-root=packages', '--package-root=packages',