firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary null checks in ‘dev/conductor’ (#118843)

Browse Source 
* Remove unnecessary null checks in dev/conductor

* review
This commit is contained in:
Michael Goderbauer 2023-01-19 20:04:08 -08:00 committed by GitHub
parent 9acf34d0d9
commit ec51d3271e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/conductor/core/lib/src/globals.dart
View File

@ -126,7 +126,7 @@ List<String> getValuesFromEnvOrArgs(
if (env[envName] != null && env[envName] != '') { if (env[envName] != null && env[envName] != '') {
return env[envName]!.split(','); return env[envName]!.split(',');
} }
final List<String> argValues = argResults[name] as List<String>; final List<String>? argValues = argResults[name] as List<String>?;
if (argValues != null) { if (argValues != null) {
return argValues; return argValues;
} }

2
dev/conductor/core/lib/src/repository.dart
View File

@ -28,7 +28,6 @@ class Remote {
required RemoteName name, required RemoteName name,
required this.url, required this.url,
}) : _name = name, }) : _name = name,
assert(url != null),
assert(url != ''); assert(url != '');
factory Remote.mirror(String url) { factory Remote.mirror(String url) {
@ -241,7 +240,6 @@ abstract class Repository {
/// The URL of the remote named [remoteName]. /// The URL of the remote named [remoteName].
Future<String> remoteUrl(String remoteName) async { Future<String> remoteUrl(String remoteName) async {
assert(remoteName != null);
return git.getOutput( return git.getOutput(
<String>['remote', 'get-url', remoteName], <String>['remote', 'get-url', remoteName],
'verify the URL of the $remoteName remote', 'verify the URL of the $remoteName remote',

4
dev/conductor/core/lib/src/state.dart
View File

@ -86,8 +86,7 @@ String presentState(pb.ConductorState state) {
} else { } else {
buffer.writeln('0 Engine cherrypicks.'); buffer.writeln('0 Engine cherrypicks.');
} }
if (state.engine.dartRevision != null && if (state.engine.dartRevision.isNotEmpty) {
state.engine.dartRevision.isNotEmpty) {
buffer.writeln('New Dart SDK revision: ${state.engine.dartRevision}'); buffer.writeln('New Dart SDK revision: ${state.engine.dartRevision}');
} }
buffer.writeln('Framework Repo'); buffer.writeln('Framework Repo');
@ -271,7 +270,6 @@ String githubAccount(String remoteUrl) {
/// Will throw a [ConductorException] if [ReleasePhase.RELEASE_COMPLETED] is /// Will throw a [ConductorException] if [ReleasePhase.RELEASE_COMPLETED] is
/// passed as an argument, as there is no next phase. /// passed as an argument, as there is no next phase.
ReleasePhase getNextPhase(ReleasePhase currentPhase) { ReleasePhase getNextPhase(ReleasePhase currentPhase) {
assert(currentPhase != null);
final ReleasePhase? nextPhase = ReleasePhase.valueOf(currentPhase.value + 1); final ReleasePhase? nextPhase = ReleasePhase.valueOf(currentPhase.value + 1);
if (nextPhase == null) { if (nextPhase == null) {
throw globals.ConductorException('There is no next ReleasePhase!'); throw globals.ConductorException('There is no next ReleasePhase!');

1
dev/conductor/core/lib/src/version.dart
View File

@ -77,7 +77,6 @@ class Version {
/// `flutter --version` and match one of `stablePattern`, `developmentPattern` /// `flutter --version` and match one of `stablePattern`, `developmentPattern`
/// and `latestPattern`. /// and `latestPattern`.
factory Version.fromString(String versionString) { factory Version.fromString(String versionString) {
assert(versionString != null);
versionString = versionString.trim(); versionString = versionString.trim();
// stable tag // stable tag