firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Fix _LateInitializationError for RenderObjectElement.renderObject (#70974)" (#73575)

Browse Source 
This reverts commit c243d834ce41bc5d279b0264efbc6b3c9e0df53d.
This commit is contained in:
Michael Goderbauer 2021-01-08 10:24:10 -08:00 committed by GitHub
parent c243d834ce
commit edfb6305d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/flutter/lib/src/widgets/framework.dart
View File

@ -5463,8 +5463,8 @@ abstract class RenderObjectElement extends Element {
/// The underlying [RenderObject] for this element. /// The underlying [RenderObject] for this element.
@override @override
RenderObject get renderObject => _renderObject!; RenderObject get renderObject => _renderObject;
RenderObject? _renderObject; late RenderObject _renderObject;
bool _debugDoingBuild = false; bool _debugDoingBuild = false;
@override @override
@ -5566,7 +5566,7 @@ abstract class RenderObjectElement extends Element {
void _debugUpdateRenderObjectOwner() { void _debugUpdateRenderObjectOwner() {
assert(() { assert(() {
renderObject.debugCreator = DebugCreator(this); _renderObject.debugCreator = DebugCreator(this);
return true; return true;
}()); }());
} }
@ -6058,7 +6058,7 @@ abstract class RenderObjectElement extends Element {
@override @override
void debugFillProperties(DiagnosticPropertiesBuilder properties) { void debugFillProperties(DiagnosticPropertiesBuilder properties) {
super.debugFillProperties(properties); super.debugFillProperties(properties);
properties.add(DiagnosticsProperty<RenderObject>('renderObject', _renderObject, defaultValue: null)); properties.add(DiagnosticsProperty<RenderObject>('renderObject', renderObject, defaultValue: null));
} }
} }

10
packages/flutter/test/widgets/framework_test.dart
View File

@ -1494,12 +1494,6 @@ void main() {
expect(GestureBinding.instance!.pointerRouter.debugGlobalRouteCount, pointerRouterCount); expect(GestureBinding.instance!.pointerRouter.debugGlobalRouteCount, pointerRouterCount);
expect(RawKeyboard.instance.keyEventHandler, same(rawKeyEventHandler)); expect(RawKeyboard.instance.keyEventHandler, same(rawKeyEventHandler));
}); });
testWidgets('Can access debugFillProperties without _LateInitializationError', (WidgetTester tester) async {
final DiagnosticPropertiesBuilder builder = DiagnosticPropertiesBuilder();
TestRenderObjectElement().debugFillProperties(builder);
expect(builder.properties.any((DiagnosticsNode property) => property.name == 'renderObject' && property.value == null), isTrue);
});
} }
class _FakeFocusManager implements FocusManager { class _FakeFocusManager implements FocusManager {
@ -1843,7 +1837,3 @@ class FakeLeafRenderObject extends RenderBox {
size = constraints.biggest; size = constraints.biggest;
} }
} }
class TestRenderObjectElement extends RenderObjectElement {
TestRenderObjectElement() : super(Table());
}