From ee3fcafcb76dfa431689a2e9709990f8313fa957 Mon Sep 17 00:00:00 2001
From: Ian Hickson <ian@hixie.ch>
Date: Tue, 28 Mar 2017 17:15:56 -0700
Subject: [PATCH] Allow hit testing dirty boxes if they have a size. (#9060)

The new scrolling world marks nodes dirty between frames instead of
waiting for the frame, and we've decided that's actually ok.

There's no test here because the test harness has a bug that hides
this exception. I will submit a separate PR to fix the harness, which
will fix a test that, without _this_ patch, fails. All of which is to
say, this is actually already tested.
---
 packages/flutter/lib/src/rendering/box.dart | 31 +++++++++++----------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/packages/flutter/lib/src/rendering/box.dart b/packages/flutter/lib/src/rendering/box.dart
index ffa0d0d60c..28e2888de9 100644
--- a/packages/flutter/lib/src/rendering/box.dart
+++ b/packages/flutter/lib/src/rendering/box.dart
@@ -1694,25 +1694,28 @@ abstract class RenderBox extends RenderObject {
   /// even through it does not [paint] its children.
   bool hitTest(HitTestResult result, { @required Point position }) {
     assert(() {
-      if (debugNeedsLayout) {
-        throw new FlutterError(
-          'Cannot hit test a dirty render box.\n'
-          'The hitTest() method was called on this RenderBox:\n'
-          '  $this\n'
-          'Unfortunately, since this object has been marked as needing layout, its geometry is not known at this time. '
-          'This means it cannot be accurately hit-tested. Make sure to only mark nodes as needing layout during a pipeline '
-          'flush, so that it is marked clean before any event handling occurs. If you are trying to perform a hit test '
-          'during the layout phase itself, make sure you only hit test nodes that have completed layout (e.g. the node\'s '
-          'children, after their layout() method has been called).'
-        );
-      }
       if (!hasSize) {
+        if (debugNeedsLayout) {
+          throw new FlutterError(
+            'Cannot hit test a render box that has never been laid out.\n'
+            'The hitTest() method was called on this RenderBox:\n'
+            '  $this\n'
+            'Unfortunately, this object\'s geometry is not known at this time, '
+            'probably because it has never been laid out. '
+            'This means it cannot be accurately hit-tested. If you are trying '
+            'to perform a hit test during the layout phase itself, make sure '
+            'you only hit test nodes that have completed layout (e.g. the node\'s '
+            'children, after their layout() method has been called).'
+          );
+        }
         throw new FlutterError(
           'Cannot hit test a render box with no size.\n'
           'The hitTest() method was called on this RenderBox:\n'
           '  $this\n'
-          'Although this node is not marked as needing layout, its size is not set. A RenderBox object must have an '
-          'explicit size before it can be hit-tested. Make sure that the RenderBox in question sets its size during layout.'
+          'Although this node is not marked as needing layout, '
+          'its size is not set. A RenderBox object must have an '
+          'explicit size before it can be hit-tested. Make sure '
+          'that the RenderBox in question sets its size during layout.'
         );
       }
       return true;