firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] remove API 30 restriction for SurfaceControl testing. (#161438)

Browse Source 
In order to give a minimal repro for the AHB issues to folks, I need to
be able to show that while it _should_ work on API 29 it doesn't in a
number of places.. Since this AHB swapchain is off by default this will
have no impact on production applications.
This commit is contained in:
Jonah Williams 2025-01-13 09:41:50 -08:00 committed by GitHub
parent 72db8f69e3
commit ee8aab77fe
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/ahb/ahb_swapchain_impl_vk.cc
View File

@ -194,8 +194,11 @@ bool AHBSwapchainImplVK::Present(
void AHBSwapchainImplVK::AddFinalCommandBuffer(
std::shared_ptr<CommandBuffer> cmd_buffer) {
FML_DCHECK(!pending_cmd_buffer_);
pending_cmd_buffer_ = std::move(cmd_buffer);
auto context = transients_->GetContext().lock();
if (!context) {
return;
}
context->GetCommandQueue()->Submit({std::move(cmd_buffer)});
}
std::shared_ptr<ExternalFenceVK>
@ -210,7 +213,7 @@ AHBSwapchainImplVK::SubmitSignalForPresentReady(
return nullptr;
}
auto command_buffer = pending_cmd_buffer_;
auto command_buffer = context->CreateCommandBuffer();
if (!command_buffer) {
return nullptr;
}

2
engine/src/flutter/impeller/toolkit/android/surface_control.cc
View File

@ -55,7 +55,7 @@ bool SurfaceControl::IsAvailableOnPlatform() {
// we had more time to test all of these older devices maybe we could
// figure out what the problem is.
// https://github.com/flutter/flutter/issues/155877
return api_level >= 30 && GetProcTable().IsValid() &&
return api_level >= 29 && GetProcTable().IsValid() &&
GetProcTable().ASurfaceControl_createFromWindow.IsAvailable();
}