firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make _initRootBundle more robust

Browse Source 
Rather than catching every exception, we now handle the one specific case where
we legitimately cannot create the root bundle.

Fixes #900
This commit is contained in:
Adam Barth 2016-03-04 12:17:21 -08:00
parent 3cb4984909
commit eea4bae674
2 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/flutter/lib/src/services/asset_bundle.dart
View File

@ -96,14 +96,11 @@ class MojoAssetBundle extends CachingAssetBundle {
}
AssetBundle _initRootBundle() {
try {
AssetBundleProxy bundle = new AssetBundleProxy.fromHandle(
new core.MojoHandle(ui.takeRootBundleHandle())
);
return new MojoAssetBundle(bundle);
} catch (e) {
int h = ui.takeRootBundleHandle();
if (h == core.MojoHandle.INVALID)
return null;
}
core.MojoHandle handle = new core.MojoHandle(h);
return new MojoAssetBundle(new AssetBundleProxy.fromHandle(handle));
}
final AssetBundle rootBundle = _initRootBundle();

6
packages/flutter/lib/src/services/print.dart
View File

@ -46,9 +46,5 @@ void _debugPrintTask() {
}
void debugPrintStack() {
try {
throw new Exception();
} catch (e, stack) {
debugPrint(stack.toString());
}
debugPrint(StackTrace.current.toString());
}