firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix finish translation for tab labels (#130333)

Browse Source 
## Description

This PR update the finnish translations for tab label.

## Related Issue

fixes https://github.com/flutter/flutter/issues/110451

## Tests

Adds 2 tests.
This commit is contained in:
Bruno Leroux 2023-07-14 17:04:40 +02:00 committed by GitHub
parent b8fa923386
commit ef312048e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_localizations/lib/src/l10n/cupertino_fi.arb
View File

@ -19,7 +19,7 @@
"copyButtonLabel": "Kopioi",
"pasteButtonLabel": "Liitä",
"selectAllButtonLabel": "Valitse kaikki",
"tabSemanticsLabel": "Välilehti $tabIndex/$tabCount",
"tabSemanticsLabel": "Välilehti $tabIndex kautta $tabCount",
"modalBarrierDismissLabel": "Ohita",
"searchTextFieldPlaceholderLabel": "Hae",
"noSpellCheckReplacementsLabel": "No Replacements Found"

2
packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart
View File

@ -3983,7 +3983,7 @@ class CupertinoLocalizationFi extends GlobalCupertinoLocalizations {
String get selectAllButtonLabel => 'Valitse kaikki';
@override
String get tabSemanticsLabelRaw => r'Välilehti $tabIndex/$tabCount';
String get tabSemanticsLabelRaw => r'Välilehti $tabIndex kautta $tabCount';
@override
String? get timerPickerHourLabelFew => null;

2
packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart
View File

@ -14206,7 +14206,7 @@ class MaterialLocalizationFi extends GlobalMaterialLocalizations {
String get signedInLabel => 'Kirjautunut sisään';
@override
String get tabLabelRaw => r'Välilehti $tabIndex/$tabCount';
String get tabLabelRaw => r'Välilehti $tabIndex kautta $tabCount';
@override
TimeOfDayFormat get timeOfDayFormatRaw => TimeOfDayFormat.HH_dot_mm;

2
packages/flutter_localizations/lib/src/l10n/material_fi.arb
View File

@ -17,7 +17,7 @@
"pageRowsInfoTitle": "$firstRow–$lastRow/$rowCount",
"pageRowsInfoTitleApproximate": "$firstRow–$lastRow/~$rowCount",
"rowsPerPageTitle": "Riviä/sivu:",
"tabLabel": "Välilehti $tabIndex/$tabCount",
"tabLabel": "Välilehti $tabIndex kautta $tabCount",
"selectedRowCountTitleOne": "1 kohde valittu",
"selectedRowCountTitleOther": "$selectedRowCount kohdetta valittu",
"cancelButtonLabel": "Peru",

9
packages/flutter_localizations/test/cupertino/translations_test.dart
View File

@ -194,4 +194,13 @@ void main() {
expect(file.readAsStringSync(), encodedArbFile);
}
});
// Regression test for https://github.com/flutter/flutter/issues/110451.
testWidgets('Finnish translation for tab label', (WidgetTester tester) async {
const Locale locale = Locale('fi');
expect(GlobalCupertinoLocalizations.delegate.isSupported(locale), isTrue);
final CupertinoLocalizations localizations = await GlobalCupertinoLocalizations.delegate.load(locale);
expect(localizations, isA<CupertinoLocalizationFi>());
expect(localizations.tabSemanticsLabel(tabIndex: 1, tabCount: 2), 'Välilehti 1 kautta 2');
});
}

9
packages/flutter_localizations/test/material/translations_test.dart
View File

@ -528,4 +528,13 @@ void main() {
expect(file.readAsStringSync(), encodedArbFile);
}
});
// Regression test for https://github.com/flutter/flutter/issues/110451.
testWidgets('Finnish translation for tab label', (WidgetTester tester) async {
const Locale locale = Locale('fi');
expect(GlobalCupertinoLocalizations.delegate.isSupported(locale), isTrue);
final MaterialLocalizations localizations = await GlobalMaterialLocalizations.delegate.load(locale);
expect(localizations, isA<MaterialLocalizationFi>());
expect(localizations.tabLabel(tabIndex: 1, tabCount: 2), 'Välilehti 1 kautta 2');
});
}