From ef99fcbd60c53202988e54203461c4f6dbabe5cb Mon Sep 17 00:00:00 2001 From: "auto-submit[bot]" <98614782+auto-submit[bot]@users.noreply.github.com> Date: Thu, 24 Oct 2024 18:20:47 +0000 Subject: [PATCH] Reverts "Added a warning if `flutter.groovy` uses a `.flutter-plugins` file. (#157388)" (#157541) Reverts: flutter/flutter#157388 Initiated by: matanlurey Reason for reverting: We have `--fatal-warnings` on postsubmit and this breaks the tree. Original PR Author: matanlurey Reviewed By: {reidbaker} This change reverts the following previous change: Work towards https://github.com/flutter/flutter/issues/48918. This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut). --- packages/flutter_tools/gradle/src/main/groovy/flutter.groovy | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy b/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy index fbbca50bf0..cbd2a5625a 100644 --- a/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy +++ b/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy @@ -688,10 +688,6 @@ class FlutterPlugin implements Plugin { } catch (FileNotFoundException ignored) { throw new GradleException("settings.gradle/settings.gradle.kts does not exist: ${settingsGradleFile(project).absolutePath}") } - // TODO(matanlurey): https://github.com/flutter/flutter/issues/48918. - project.logger.quiet("Warning: This project is still reading the deprecated '.flutter-plugins. file.") - project.logger.quiet("In an upcoming stable release support for this file will be completely removed and your build will fail.") - project.logger.quiet("See https:/flutter.dev/to/flutter-plugins-configuration.") List> deps = getPluginDependencies(project) List plugins = getPluginList(project).collect { it.name as String } deps.removeIf { plugins.contains(it.name) }