firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update doc (#113778)

Browse Source 
Update recipes doc with correct parameters
This commit is contained in:
keyonghan 2023-02-28 17:21:56 -08:00 committed by GitHub
parent 0cd6f1fbdb
commit f028f97e8c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dev/bots/README.md
View File

@ -73,9 +73,8 @@ The typical cycle for editing a recipe is:
the existing expected output to match the new output. Verify completely new test the existing expected output to match the new output. Verify completely new test
cases by altering the `GenTests` method of the recipe. The recipe is required cases by altering the `GenTests` method of the recipe. The recipe is required
to have 100% test coverage. to have 100% test coverage.
4. Run `led get-builder 'luci.flutter.staging:BUILDER_NAME' | led edit -p 'revision="GIT_HASH"' | led edit-recipe-bundle | led launch`, where `BUILDER_NAME` is the builder name (e.g. `Linux Engine`), and 4. Run `led get-builder 'luci.flutter.staging:BUILDER_NAME' | led edit -pa git_ref='refs/pull/<PR number>/head' | led edit -pa git_url='https://github.com/flutter/<repo>' | led edit-recipe-bundle | led launch`, where `BUILDER_NAME` is the builder name (e.g. `Linux Engine`), and
`GIT_HASH` is the hash to build (which is important for the engine but not `git_ref`/`git_url` is the ref/url of the intended changes to build.
for the framework).
* If `led` fails, ensure that your `depot_tools` checkout is up to date. * If `led` fails, ensure that your `depot_tools` checkout is up to date.
5. To submit a CL, you need a local branch first (`git checkout -b [some branch name]`). 5. To submit a CL, you need a local branch first (`git checkout -b [some branch name]`).
6. Upload the patch (`git commit`, `git cl upload`), and open the outputted URL to the CL. 6. Upload the patch (`git commit`, `git cl upload`), and open the outputted URL to the CL.