firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "PlatformRouteInformationProvider should dispatch creation in constructor." (#133479)

Browse Source 
Reverts flutter/flutter#133353

Tree is failing on Mac and Linux customer_testing on this PR.
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20customer_testing/14646/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20customer_testing/14974/overview
This commit is contained in:
Victoria Ashworth 2023-08-28 13:13:21 -05:00 committed by GitHub
parent 76d6d36b7a
commit f1f46ef2d3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter/lib/src/widgets/router.dart
View File

@ -1465,11 +1465,7 @@ class PlatformRouteInformationProvider extends RouteInformationProvider with Wid
/// provider.
PlatformRouteInformationProvider({
required RouteInformation initialRouteInformation,
}) : _value = initialRouteInformation {
if (kFlutterMemoryAllocationsEnabled) {
maybeDispatchObjectCreation();
}
}
}) : _value = initialRouteInformation;
static bool _equals(Uri a, Uri b) {
return a.path == b.path

1
packages/flutter/test/material/app_test.dart
View File

@ -1161,7 +1161,6 @@ void main() {
routerDelegate: delegate,
));
expect(tester.takeException(), isAssertionError);
provider.dispose();
});
testWidgetsWithLeakTracking('MaterialApp.router throw if route configuration is provided along with other delegate', (WidgetTester tester) async {

15
packages/flutter/test/widgets/router_test.dart
View File

@ -1582,21 +1582,6 @@ testWidgets('ChildBackButtonDispatcher take priority recursively', (WidgetTester
expect(info2.location, '/abc?def=ghi&def=jkl#mno');
});
});
test('$PlatformRouteInformationProvider dispatches object creation in constructor', () {
int eventCount = 0;
void listener(ObjectEvent event) => eventCount++;
MemoryAllocations.instance.addListener(listener);
final PlatformRouteInformationProvider registry = PlatformRouteInformationProvider(
initialRouteInformation: RouteInformation(uri: Uri.parse('http://google.com')),
);
expect(eventCount, 1);
registry.dispose();
MemoryAllocations.instance.removeListener(listener);
});
}
Widget buildBoilerPlate(Widget child) {