firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix bug in setPreferredOrientations example (#133503)

Browse Source 
The `ui.Display` is a simple data class (like `MediaQueryData`), and does not get updated when the display size changes.  The provided sample code does not work as intended, but the update does.
This commit is contained in:
Dan Field 2023-08-28 23:29:05 -07:00 committed by GitHub
parent 6dae269881
commit f489256fce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/flutter/lib/src/services/system_chrome.dart
View File

@ -388,7 +388,7 @@ abstract final class SystemChrome {
/// }
///
/// class _MyAppState extends State<MyApp> with WidgetsBindingObserver {
/// ui.Display? _display;
/// ui.FlutterView? _view;
/// static const double kOrientationLockBreakpoint = 600;
///
/// @override
@ -400,19 +400,19 @@ abstract final class SystemChrome {
/// @override
/// void didChangeDependencies() {
/// super.didChangeDependencies();
/// _display = View.maybeOf(context)?.display;
/// _view = View.maybeOf(context);
/// }
///
/// @override
/// void dispose() {
/// WidgetsBinding.instance.removeObserver(this);
/// _display = null;
/// _view = null;
/// super.dispose();
/// }
///
/// @override
/// void didChangeMetrics() {
/// final ui.Display? display = _display;
/// final ui.Display? display = _view?.display;
/// if (display == null) {
/// return;
/// }