firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add header SemanticsFlag to bottom nav bar (#19803)

Browse Source
This commit is contained in:
Jonah Williams 2018-07-26 13:29:28 -07:00 committed by GitHub
parent 70791c3087
commit f516074a98
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/flutter/lib/src/material/bottom_navigation_bar.dart
View File

@ -277,6 +277,7 @@ class _BottomNavigationTile extends StatelessWidget {
flex: size,
child: new Semantics(
container: true,
header: true,
selected: selected,
child: new Stack(
children: <Widget>[

11
packages/flutter/test/material/bottom_navigation_bar_test.dart
View File

@ -574,19 +574,28 @@ void main() {
children: <TestSemantics>[
new TestSemantics(
id: 3,
flags: <SemanticsFlag>[SemanticsFlag.isSelected],
flags: <SemanticsFlag>[
SemanticsFlag.isSelected,
SemanticsFlag.isHeader,
],
actions: <SemanticsAction>[SemanticsAction.tap],
label: 'AC\nTab 1 of 3',
textDirection: TextDirection.ltr,
),
new TestSemantics(
id: 4,
flags: <SemanticsFlag>[
SemanticsFlag.isHeader,
],
actions: <SemanticsAction>[SemanticsAction.tap],
label: 'Alarm\nTab 2 of 3',
textDirection: TextDirection.ltr,
),
new TestSemantics(
id: 5,
flags: <SemanticsFlag>[
SemanticsFlag.isHeader,
],
actions: <SemanticsAction>[SemanticsAction.tap],
label: 'Hot Tub\nTab 3 of 3',
textDirection: TextDirection.ltr,