From f5e8fc35f0f4578224468377b2fab9d899d1f58c Mon Sep 17 00:00:00 2001 From: Srujan Gaddam <58529443+srujzs@users.noreply.github.com> Date: Tue, 4 Feb 2025 12:10:20 -0800 Subject: [PATCH] Skip web hot reload tests that test execution for all platforms for now (#162682) https://github.com/flutter/flutter/issues/162567 There's a general timing error that may occur when loading scripts, where main might be run before the scripts are done loading, leading to a crash. These tests test that output is being printed to stdout, and wait forever for that, leading to timeouts. This is flaky, so the race condition may or may not occur. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. Example of a timeout: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_tool_tests/50762/overview --- .../flutter_tools/test/web.shard/hot_reload_web_test.dart | 4 +--- .../test/web.shard/hot_reload_with_asset_web_test.dart | 4 +--- .../web.shard/stateless_stateful_hot_reload_web_test.dart | 4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/packages/flutter_tools/test/web.shard/hot_reload_web_test.dart b/packages/flutter_tools/test/web.shard/hot_reload_web_test.dart index d57ba36c1d..1ecce26566 100644 --- a/packages/flutter_tools/test/web.shard/hot_reload_web_test.dart +++ b/packages/flutter_tools/test/web.shard/hot_reload_web_test.dart @@ -5,8 +5,6 @@ @Tags(['flutter-test-driver']) library; -import 'dart:io'; - import '../integration.shard/test_data/hot_reload_test_common.dart'; import '../src/common.dart'; @@ -17,6 +15,6 @@ void main() { '--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc', ], // https://github.com/flutter/flutter/issues/162567 - skip: Platform.isWindows, + skip: true, ); } diff --git a/packages/flutter_tools/test/web.shard/hot_reload_with_asset_web_test.dart b/packages/flutter_tools/test/web.shard/hot_reload_with_asset_web_test.dart index d447f0ee34..00f9fb7984 100644 --- a/packages/flutter_tools/test/web.shard/hot_reload_with_asset_web_test.dart +++ b/packages/flutter_tools/test/web.shard/hot_reload_with_asset_web_test.dart @@ -5,8 +5,6 @@ @Tags(['flutter-test-driver']) library; -import 'dart:io'; - import '../integration.shard/test_data/hot_reload_with_asset_test_common.dart'; import '../src/common.dart'; @@ -17,6 +15,6 @@ void main() { '--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc', ], // https://github.com/flutter/flutter/issues/162567 - skip: Platform.isWindows, + skip: true, ); } diff --git a/packages/flutter_tools/test/web.shard/stateless_stateful_hot_reload_web_test.dart b/packages/flutter_tools/test/web.shard/stateless_stateful_hot_reload_web_test.dart index e5101085f7..d5e8c57da0 100644 --- a/packages/flutter_tools/test/web.shard/stateless_stateful_hot_reload_web_test.dart +++ b/packages/flutter_tools/test/web.shard/stateless_stateful_hot_reload_web_test.dart @@ -5,8 +5,6 @@ @Tags(['flutter-test-driver']) library; -import 'dart:io'; - import '../integration.shard/test_data/stateless_stateful_hot_reload_test_common.dart'; import '../src/common.dart'; @@ -17,6 +15,6 @@ void main() { '--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc', ], // https://github.com/flutter/flutter/issues/162567 - skip: Platform.isWindows, + skip: true, ); }