firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[flutter_tools] Add documentation to "cmdline-tools component is missing" doctor validation error (#83356)

Browse Source
This commit is contained in:
Taha Tesser 2021-05-26 20:59:02 +03:00 committed by GitHub
parent b9377f358c
commit f9cd87e60a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/android/android_workflow.dart
View File

@ -186,7 +186,7 @@ class AndroidValidator extends DoctorValidator {
return ValidationResult(ValidationType.missing, messages); return ValidationResult(ValidationType.missing, messages);
} }
if (!androidSdk.cmdlineToolsAvailable) { if (!androidSdk.cmdlineToolsAvailable) {
messages.add(const ValidationMessage.error('cmdline-tools component is missing')); messages.add(ValidationMessage.error(_userMessages.androidMissingCmdTools));
return ValidationResult(ValidationType.missing, messages); return ValidationResult(ValidationType.missing, messages);
} }

3
packages/flutter_tools/lib/src/base/user_messages.dart
View File

@ -120,6 +120,9 @@ class UserMessages {
String androidSdkBuildToolsOutdated(String managerPath, int sdkMinVersion, String buildToolsMinVersion, Platform platform) => String androidSdkBuildToolsOutdated(String managerPath, int sdkMinVersion, String buildToolsMinVersion, Platform platform) =>
'Flutter requires Android SDK $sdkMinVersion and the Android BuildTools $buildToolsMinVersion\n' 'Flutter requires Android SDK $sdkMinVersion and the Android BuildTools $buildToolsMinVersion\n'
'To update the Android SDK visit ${_androidSdkInstallUrl(platform)} for detailed instructions.'; 'To update the Android SDK visit ${_androidSdkInstallUrl(platform)} for detailed instructions.';
String get androidMissingCmdTools => 'cmdline-tools component is missing\n'
'Run `path/to/sdkmanager --install "cmdline-tools;latest"`\n'
'See https://developer.android.com/studio/command-line for more details.';
// Messages used in AndroidStudioValidator // Messages used in AndroidStudioValidator
String androidStudioVersion(String version) => 'version $version'; String androidStudioVersion(String version) => 'version $version';

4
packages/flutter_tools/test/general.shard/android/android_workflow_test.dart
View File

@ -395,11 +395,13 @@ Review licenses that have not been accepted (y/N)?
userMessages: UserMessages(), userMessages: UserMessages(),
); );
final String errorMessage = UserMessages().androidMissingCmdTools;
final ValidationResult validationResult = await androidValidator.validate(); final ValidationResult validationResult = await androidValidator.validate();
expect(validationResult.type, ValidationType.missing); expect(validationResult.type, ValidationType.missing);
expect( expect(
validationResult.messages.last.message, validationResult.messages.last.message,
'cmdline-tools component is missing', errorMessage,
); );
}); });