From fa646339d65a775bf0dd4c06655b65fc122c38ab Mon Sep 17 00:00:00 2001 From: gaaclarke <30870216+gaaclarke@users.noreply.github.com> Date: Wed, 16 Sep 2020 17:47:04 -0700 Subject: [PATCH] Added the machine's architecture to macos doctor results. (#65978) --- packages/flutter_tools/lib/src/base/os.dart | 3 ++- .../test/general.shard/base/os_test.dart | 23 +++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/packages/flutter_tools/lib/src/base/os.dart b/packages/flutter_tools/lib/src/base/os.dart index e57a8bc4f4..bb0ab5a331 100644 --- a/packages/flutter_tools/lib/src/base/os.dart +++ b/packages/flutter_tools/lib/src/base/os.dart @@ -253,10 +253,11 @@ class _PosixUtils extends OperatingSystemUtils { _processUtils.runSync(['sw_vers', '-productName']), _processUtils.runSync(['sw_vers', '-productVersion']), _processUtils.runSync(['sw_vers', '-buildVersion']), + _processUtils.runSync(['uname', '-m']), ]; if (results.every((RunResult result) => result.exitCode == 0)) { _name = '${results[0].stdout.trim()} ${results[1].stdout - .trim()} ${results[2].stdout.trim()}'; + .trim()} ${results[2].stdout.trim()} ${results[3].stdout.trim()}'; } } _name ??= super.name; diff --git a/packages/flutter_tools/test/general.shard/base/os_test.dart b/packages/flutter_tools/test/general.shard/base/os_test.dart index b6977361a6..3e9fca1780 100644 --- a/packages/flutter_tools/test/general.shard/base/os_test.dart +++ b/packages/flutter_tools/test/general.shard/base/os_test.dart @@ -95,6 +95,29 @@ void main() { }); }); + testWithoutContext('macos name', () async { + when(mockProcessManager.runSync( + ['sw_vers', '-productName'], + )).thenReturn(ProcessResult(0, 0, 'product', '')); + when(mockProcessManager.runSync( + ['sw_vers', '-productVersion'], + )).thenReturn(ProcessResult(0, 0, 'version', '')); + when(mockProcessManager.runSync( + ['sw_vers', '-buildVersion'], + )).thenReturn(ProcessResult(0, 0, 'build', '')); + when(mockProcessManager.runSync( + ['uname', '-m'], + )).thenReturn(ProcessResult(0, 0, 'arch', '')); + final MockFileSystem fileSystem = MockFileSystem(); + final OperatingSystemUtils utils = OperatingSystemUtils( + fileSystem: fileSystem, + logger: BufferLogger.test(), + platform: FakePlatform(operatingSystem: 'macos'), + processManager: mockProcessManager, + ); + expect(utils.name, 'product version build arch'); + }); + testWithoutContext('If unzip fails, include stderr in exception text', () { const String exceptionMessage = 'Something really bad happened.'; when(mockProcessManager.runSync(