From fac051c778c255e4dc5b01c308b8cf8302283953 Mon Sep 17 00:00:00 2001 From: Jacob Richman Date: Thu, 31 Jan 2019 19:49:32 -0800 Subject: [PATCH] Fix bug in diagnostics for UnconstrainedBox class. (#27381) --- packages/flutter/lib/src/widgets/basic.dart | 4 ++-- packages/flutter/test/widgets/basic_test.dart | 11 +++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/packages/flutter/lib/src/widgets/basic.dart b/packages/flutter/lib/src/widgets/basic.dart index 5db16c9b4d..be070c47ab 100644 --- a/packages/flutter/lib/src/widgets/basic.dart +++ b/packages/flutter/lib/src/widgets/basic.dart @@ -2068,8 +2068,8 @@ class UnconstrainedBox extends SingleChildRenderObjectWidget { void debugFillProperties(DiagnosticPropertiesBuilder properties) { super.debugFillProperties(properties); properties.add(DiagnosticsProperty('alignment', alignment)); - properties.add(DiagnosticsProperty('constrainedAxis', null)); - properties.add(DiagnosticsProperty('textDirection', textDirection, defaultValue: null)); + properties.add(EnumProperty('constrainedAxis', constrainedAxis, defaultValue: null)); + properties.add(EnumProperty('textDirection', textDirection, defaultValue: null)); } } diff --git a/packages/flutter/test/widgets/basic_test.dart b/packages/flutter/test/widgets/basic_test.dart index 95d491a384..3c7b894b05 100644 --- a/packages/flutter/test/widgets/basic_test.dart +++ b/packages/flutter/test/widgets/basic_test.dart @@ -145,6 +145,17 @@ void main() { expect(_pointerDown, isTrue); }); }); + + test('UnconstrainedBox toString', () { + expect( + const UnconstrainedBox(constrainedAxis: Axis.vertical,).toString(), + equals('UnconstrainedBox(alignment: center, constrainedAxis: vertical)'), + ); + expect( + const UnconstrainedBox(constrainedAxis: Axis.horizontal, textDirection: TextDirection.rtl, alignment: Alignment.topRight).toString(), + equals('UnconstrainedBox(alignment: topRight, constrainedAxis: horizontal, textDirection: rtl)'), + ); + }); } HitsRenderBox hits(RenderBox renderBox) => HitsRenderBox(renderBox);