From fba8c5770f1d16f4cbf3e729f1e345ef3b7bf899 Mon Sep 17 00:00:00 2001 From: Mohellebi abdessalem Date: Mon, 21 Oct 2024 20:56:18 +0100 Subject: [PATCH] fix `Consider using 'named' to avoid unnecessary configuration` inside flutter.groovy (#157221) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit see #147122 for context [gradle docs](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html) for reference(scroll until [this)](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#eager_apis_to_avoid) also this the lint : ![Capture d’écran 2024-10-19 094417](https://github.com/user-attachments/assets/8278c72e-068e-4596-b1ce-7888161bfcc8) --- .../gradle/src/main/groovy/flutter.groovy | 28 +++++++++---------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy b/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy index 8c2ea18569..da4ddc9338 100644 --- a/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy +++ b/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy @@ -14,6 +14,7 @@ import org.gradle.api.JavaVersion import org.gradle.api.Project import org.gradle.api.Plugin import org.gradle.api.Task +import org.gradle.api.UnknownTaskException import org.gradle.api.file.CopySpec import org.gradle.api.file.FileCollection import org.gradle.api.logging.LogLevel @@ -1359,24 +1360,21 @@ class FlutterPlugin implements Plugin { // The following tasks use the output of copyFlutterAssetsTask, // so it's necessary to declare it as an dependency since Gradle 8. // See https://docs.gradle.org/8.1/userguide/validation_problems.html#implicit_dependency. - def compressAssetsTask = project.tasks.findByName("compress${variant.name.capitalize()}Assets") - if (compressAssetsTask) { - compressAssetsTask.dependsOn(copyFlutterAssetsTask) + def tasksToCheck = [ + "compress${variant.name.capitalize()}Assets", + "bundle${variant.name.capitalize()}Aar", + "bundle${variant.name.capitalize()}LocalLintAar" + ] + tasksToCheck.each { taskTocheck -> + try { + project.tasks.named(taskTocheck).configure { task -> + task.dependsOn(copyFlutterAssetsTask) + } + } catch (UnknownTaskException ignored) { + } } - - def bundleAarTask = project.tasks.findByName("bundle${variant.name.capitalize()}Aar") - if (bundleAarTask) { - bundleAarTask.dependsOn(copyFlutterAssetsTask) - } - - def bundleAarTaskWithLint = project.tasks.findByName("bundle${variant.name.capitalize()}LocalLintAar") - if (bundleAarTaskWithLint) { - bundleAarTaskWithLint.dependsOn(copyFlutterAssetsTask) - } - return copyFlutterAssetsTask } // end def addFlutterDeps - if (isFlutterAppProject()) { project.android.applicationVariants.all { variant -> Task assembleTask = getAssembleTask(variant)